-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very small example added for st_geometrytype #447
base: main
Are you sure you want to change the base?
Conversation
Hi! Thanks a lot for this PR and the help on improving the docs. To add an example for e.g. ST_GeometryType you'd have to add it to the If this seems like a lot of effort feel free to leave this PR open as is and I will try to pick it up and incorporate the changes next time im working on spatial! We're planning to rework this in the future so that all functions are declared separately with their names/parameters/types/overloads/descriptions/examples in e.g. json files from which we can generate both the markdown docs and scaffold the c++ stubs from. |
No prob I'll look into this when I get a chance 👍 |
I reverted back the .md file that I manually changed and updated the function doc spec in the .cpp file but I need to troubleshoot my windows subsystem for linux setup so I can generate the build folder and then run |
Okay whew, so I was able to setup my linux env with cmake, gcc, openssl, and ninja. I then was able to successfully do The one odd thing is there a few function doc changes that I didn't add so I'm wondering if my fork wasn't up to date when I built or something? Let me know if I'm missing something @Maxxen |
When working with ST_GeometryType I was confused on what types the enum returned as well as proper usage of it
I won't be offended if you feel this is unnecessary as its a very small nit-picky change but just thought it would be helpful to add an example. Thanks for your hardwork!