Properly pass down ClientContext to ClientProperties, to be used in A…

…rrow conversion
duckdb · Feb 5, 2025 · d21c223 · d21c223
1 parent 23d7340
commit d21c223
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 82 deletions.
diff --git a/lib/src/webdb.cc b/lib/src/webdb.cc
@@ -103,7 +103,7 @@ arrow::Result<std::shared_ptr<arrow::Buffer>> WebDB::Connection::MaterializeQuer
 
     // Configure the output writer
     ArrowSchema raw_schema;
-    ClientProperties options;
+    ClientProperties options("UTC", ArrowOffsetSize::REGULAR, false, false, false, connection_.context);
     unordered_map<idx_t, const shared_ptr<ArrowTypeExtensionData>> extension_type_cast;
     options.arrow_offset_size = ArrowOffsetSize::REGULAR;
     ArrowConverter::ToArrowSchema(&raw_schema, result->types, result->names, options);
@@ -139,7 +139,7 @@ arrow::Result<std::shared_ptr<arrow::Buffer>> WebDB::Connection::StreamQueryResu
 
     // Import the schema
     ArrowSchema raw_schema;
-    ClientProperties options;
+    ClientProperties options("UTC", ArrowOffsetSize::REGULAR, false, false, false, connection_.context);
     options.arrow_offset_size = ArrowOffsetSize::REGULAR;
     ArrowConverter::ToArrowSchema(&raw_schema, current_query_result_->types, current_query_result_->names, options);
     ARROW_ASSIGN_OR_RAISE(current_schema_, arrow::ImportSchema(&raw_schema));
@@ -251,7 +251,7 @@ arrow::Result<std::shared_ptr<arrow::Buffer>> WebDB::Connection::FetchQueryResul
 
         // Serialize the record batch
         ArrowArray array;
-        ClientProperties arrow_options;
+        ClientProperties arrow_options("UTC", ArrowOffsetSize::REGULAR, false, false, false, connection_.context);
         unordered_map<idx_t, const shared_ptr<ArrowTypeExtensionData>> extension_type_cast;
         arrow_options.arrow_offset_size = ArrowOffsetSize::REGULAR;
         ArrowConverter::ToArrowArray(*chunk, &array, arrow_options, extension_type_cast);

diff --git a/patches/duckdb/add_constructor_client_properties.patch b/patches/duckdb/add_constructor_client_properties.patch
diff --git a/patches/duckdb/arrow_appender_opt_client_context.patch b/patches/duckdb/arrow_appender_opt_client_context.patch
diff --git a/patches/duckdb/arrow_converter_opt_client_context.patch b/patches/duckdb/arrow_converter_opt_client_context.patch