Fix parsing of list and map schemas from metadata JSON file #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this change broke any tests. At the least, running
makesucceeds with this change. Maybe there is a particular target I should be running to run the tests?If there are in fact no tests covering this, any recommendation on where I should add them? I've only worked in a few C++ repos (I am much more at home in Go and Java repos), so if there are any patterns or advice on writing unit tests, that would be great. But even just pointing me in the direction of similar-ish tests, so I know what new tests should roughly look like, would be great.
Fixes #47.