(fix) Add support for attaching a MotherDuck database with token in settings or config #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for attaching a MotherDuck database and pass an arbitrary token via
config
,settings
orpath
.Example profiles.yml:
Right now, this fails with an error:
This is because the
SET
command happens after theATTACH
. Similarly, when passing the token viaconfig
, this also fails, because themotherduck
extension is not yet loaded when runningduckdb.connect
. Lastly, passing the token via thepath
also fails because it's passed to theATTACH
command directly and this also does not let you set the token.Therefore, currently the only way to attach a MotherDuck database is to have the
motherduck_token
env var set.After some discussion with Josh we decided:
SET
the MotherDuck token before the md: attach happens. Similar to how the config is updated when connecting to a MD path.