Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secrets): value should be enclosed in quotes #421

Merged
merged 3 commits into from
Jul 31, 2024
Merged

fix(secrets): value should be enclosed in quotes #421

merged 3 commits into from
Jul 31, 2024

Conversation

waaronmorris
Copy link
Contributor

@waaronmorris waaronmorris mentioned this pull request Jul 31, 2024
Closed
@jwills
Copy link
Collaborator

jwills commented Jul 31, 2024

ack, thank you @waaronmorris! cc @guenp

@guenp
Copy link
Collaborator

guenp commented Jul 31, 2024

Thanks @waaronmorris, this is a great catch!
Could you also update the unit tests?

guenp
guenp requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@guenp guenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add quotes to all the unit tests - see 3190554

dbt/adapters/duckdb/secrets.py Outdated Show resolved Hide resolved
@guenp guenp merged commit 3bbc42b into duckdb:master Jul 31, 2024
31 checks passed
@waaronmorris waaronmorris deleted the fix/issue-420-secret-parse-error branch July 31, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guenp guenp guenp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waaronmorris @jwills @guenp