Fix sqlite write #299
Merged
Fix sqlite write #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwills
reviewed
Dec 1, 2023
| "type": "duckdb", | ||
| "path": dbt_profile_target.get("path", ":memory:"), | ||
| "attach": [ | ||
| {'path': sqlite_test_db} |
There was a problem hiding this comment.
Doesn't this need to have the sqlite type included? I thought the default assumed a DuckDB database was being attached
There was a problem hiding this comment.
They show this approach in the sqlite_scanner docs
I believe if the file has the .db extension it is assumed to be sqlite
| {% macro duckdb__create_schema(relation) -%} | ||
| {%- call statement('create_schema') -%} | ||
| create schema if not exists {{ relation.without_identifier() }} | ||
| {% set sql %} | ||
| select type from duckdb_databases() |
There was a problem hiding this comment.
Nit-ish question: when was this method added? I want to know if we need to do a bump from the minimal duckdb >= 0.7.0 dependency we include in setup.py
Nintorac
force-pushed
the
fix-sqlite-write
branch
from
9034654 to
0160f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291