Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more helpful error message in the case that the options argument isn't a dictionary #250

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jwills
Copy link
Collaborator

@jwills jwills commented Sep 13, 2023

A couple of different folks have hit hard-to-diagnose errors when they pass in a string for the options field in external materializations; since I need to be able to use the partition_by field in order to correctly create a view for the materialized file(s), I need to keep the options field as a dictionary and provide a more helpful error message in the situation that another variable type (e.g., a string) is passed instead.

…t to an external materialization is not a dictionary
@jwills jwills merged commit 6af8741 into master Sep 13, 2023
32 checks passed
@jwills jwills deleted the jwills_options_must_be_a_dict branch September 13, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant