Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 support to Excel plugin through env variables #230

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Add s3 support to Excel plugin through env variables #230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a06cf3
feat: add s3 support to excel plugin through env
felippecaso Aug 8, 2023
c6cb22c
fix: change quoting character
felippecaso Aug 8, 2023
e56f3b3
Update excel.py
jwills Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion dbt/adapters/duckdb/plugins/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import os
import pathlib
from typing import Any
from typing import Dict

import pandas as pd

Expand All @@ -7,9 +10,22 @@


class Plugin(BasePlugin):
def initialize(self, plugin_config: Dict[str, Any]):
# Pass s3 settings to plugin environment
if "s3_access_key_id" in plugin_config:
os.environ["AWS_ACCESS_KEY_ID"] = plugin_config["s3_access_key_id"]
if "s3_secret_access_key" in plugin_config:
os.environ["AWS_SECRET_ACCESS_KEY"] = plugin_config["s3_secret_access_key"]
if "s3_region" in plugin_config:
os.environ["AWS_DEFAULT_REGION"] = plugin_config["s3_region"]

def load(self, source_config: SourceConfig):
ext_location = source_config["external_location"]
ext_location = ext_location.format(**source_config.as_dict())
source_location = pathlib.Path(ext_location.strip("'"))
if "s3" in ext_location:
# Possible to add some treatment in the future
source_location = ext_location
else:
source_location = pathlib.Path(ext_location.strip("'"))
sheet_name = source_config.get("sheet_name", 0)
return pd.read_excel(source_location, sheet_name=sheet_name)