Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepping the dbt-duckdb tests to pass under the next release of DuckDB #166

Merged
merged 1 commit into from
May 9, 2023

Conversation

jwills
Copy link
Collaborator

@jwills jwills commented May 8, 2023

Trying a new thing where I test out dbt-duckdb against the next release of DuckDB about a week-or-so before it comes out so I can get ahead of any bug fixes or updates I need in dbt-duckdb instead of having to scramble the day of the release to get stuff fixed.

Two things I needed to fix when I ran against 0.7.2-dev:

  1. Partition columns (in the Hive-partitioned sense) are now VARCHAR types
  2. There is a breaking change to the default division operator such that it will now return floats by default instead of ints; this can be overridden by setting the integer_division setting to true, which I am doing here b/c some of the dbt tests fail without this setting in place.

@jwills jwills merged commit 092beda into master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant