Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unique_field in credentials.py #140

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Set unique_field in credentials.py #140

merged 2 commits into from
Apr 7, 2023

Conversation

aranke
Copy link
Contributor

@aranke aranke commented Apr 7, 2023

@jwills
Copy link
Collaborator

jwills commented Apr 7, 2023

@aranke thanks for this; I think the closest thing to a unique field for tracking purposes is either 1) remote.host + remote.port (if they're defined) or 2) path + external_root (if they're not.)

@aranke
Copy link
Contributor Author

aranke commented Apr 7, 2023

Updated, thanks!

@jwills jwills merged commit 9cebcb0 into duckdb:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants