Adds a remote environment for DuckDB databases running in a Buena Vista server #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
reviewed
Apr 2, 2023
| cursor.execute(f"LOAD '{ext}'") | ||
| for key, value in self.creds.load_settings().items(): | ||
| for key, value in creds.load_settings().items(): | ||
| # Okay to set these as strings because DuckDB will cast them | ||
| # to the correct type | ||
| cursor.execute(f"SET {key} = '{value}'") |
There was a problem hiding this comment.
Might be worth escaping quotes here?
There was a problem hiding this comment.
(Like, which quotes should I be escaping?)
There was a problem hiding this comment.
In the case that someone passes a string containing single quotes I mean - they should be doubled up to escape them. It's not directly relevant to this pr, just figured it was worth mentioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(using the postgres protocol)