Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream model registration redux #126

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

AlexanderVR
Copy link
Contributor

A couple more fixes for #125

  • Fix comma vs spaces causing empty test
  • Really ensure the models are getting created in this test
  • Use the upstream config to generate the upstream options.

@jwills
Copy link
Collaborator

jwills commented Mar 26, 2023

Thank you so much @AlexanderVR !

@jwills jwills merged commit d103445 into duckdb:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants