Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix path separator #120

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Fix path separator #120

merged 1 commit into from
Nov 3, 2018

Conversation

duck8823
Copy link
Owner

@duck8823 duck8823 commented Nov 3, 2018

For windows,

  • Use fpath/filepath.Join instead of path.Join.
  • Use separator os.PathSeparator insetead of /.

@duck8823 duck8823 added the maintenance Refactoring code or infrastructure label Nov 3, 2018
@duck8823 duck8823 self-assigned this Nov 3, 2018
@coveralls
Copy link

coveralls commented Nov 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 630

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.884%
Totals Coverage Status
Change from base Build 626: 0.0%
Covered Lines: 731
Relevant Lines: 787
💛 - Coveralls

@duck8823 duck8823 force-pushed the maintenance/path_separator branch from fa2ad29 to 71a7355 Compare November 3, 2018 10:58
@duck8823 duck8823 changed the title [WIP] Fix path separator Fix path separator Nov 3, 2018
@duck8823 duck8823 merged commit de9a678 into master Nov 3, 2018
@duck8823 duck8823 deleted the maintenance/path_separator branch November 3, 2018 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@duck8823 duck8823

Labels
maintenance Refactoring code or infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duck8823 @coveralls