Merge pull request #75 from duck8823/maintenance/change_container_image

Change docker images in test

infrastructure/docker/docker.go

@@ -62,6 +62,7 @@ func (c *clientImpl) Build(ctx context.Context, file io.Reader, tag string, dock
 	opts := types.ImageBuildOptions{
 		Tags:       []string{tag},
 		Dockerfile: dockerfile,
+		Remove:     true,
 	}
 	resp, err := c.moby.ImageBuild(ctx, file, opts)
 	if err != nil {
@@ -85,7 +86,7 @@ func (c *clientImpl) Run(ctx context.Context, opts RuntimeOptions, tag string, c
 	}
 
 	if err := c.moby.ContainerStart(ctx, con.ID, types.ContainerStartOptions{}); err != nil {
-		return "", nil, errors.WithStack(err)
+		return con.ID, nil, errors.WithStack(err)
 	}
 
 	log, err := c.moby.ContainerLogs(ctx, con.ID, types.ContainerLogsOptions{
@@ -94,7 +95,7 @@ func (c *clientImpl) Run(ctx context.Context, opts RuntimeOptions, tag string, c
 		Follow:     true,
 	})
 	if err != nil {
-		return "", nil, errors.WithStack(err)
+		return con.ID, nil, errors.WithStack(err)
 	}
 
 	return con.ID, &runLogger{bufio.NewReader(log)}, nil

infrastructure/docker/docker_test.go

@@ -67,6 +67,9 @@ func TestClientImpl_Build(t *testing.T) {
 			if !contains(images, fmt.Sprintf("%s:latest", tag)) {
 				t.Errorf("docker images must contains. images: %+v, tag: %+v", images, tag)
 			}
+
+			// cleanup
+			removeImage(t, tag)
 		})
 
 		t.Run("with sub directory", func(t *testing.T) {
@@ -93,6 +96,9 @@ func TestClientImpl_Build(t *testing.T) {
 			if !contains(images, fmt.Sprintf("%s:latest", tag)) {
 				t.Errorf("docker images must contains. images: %+v, tag: %+v", images, tag)
 			}
+
+			// cleanup
+			removeImage(t, tag)
 		})
 	})
 
@@ -153,10 +159,10 @@ func TestClientImpl_Run(t *testing.T) {
 			t.Parallel()
 
 			// given
-			imagePull(t, "centos:latest")
+			imagePull(t, "alpine:latest")
 
 			// when
-			containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "centos", "echo", "Hello-world")
+			containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "alpine", "echo", "Hello-world")
 			if err != nil {
 				t.Fatalf("error occured: %+v", err)
 			}
@@ -177,28 +183,32 @@ func TestClientImpl_Run(t *testing.T) {
 			t.Parallel()
 
 			// given
-			imagePull(t, "centos:latest")
+			imagePull(t, "alpine:latest")
 
 			// expect
-			if _, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "centos", "missing_command"); err == nil {
+			containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "alpine", "missing_command")
+			if err == nil {
 				t.Error("error must occur")
 			}
+
+			// cleanup
+			removeContainer(t, containerId)
 		})
 	})
 
 	t.Run("with environments", func(t *testing.T) {
 		t.Parallel()
 
 		// given
-		imagePull(t, "centos:latest")
+		imagePull(t, "alpine:latest")
 
 		// and
 		opts := docker.RuntimeOptions{
 			Environments: docker.Environments{"ENV": "hello-world"},
 		}
 
 		// when
-		containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "centos", "sh", "-c", "echo hello $ENV")
+		containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "alpine", "sh", "-c", "echo hello $ENV")
 		if err != nil {
 			t.Fatalf("error occured: %+v", err)
 		}
@@ -223,7 +233,7 @@ func TestClientImpl_Run(t *testing.T) {
 		t.Parallel()
 
 		// given
-		imagePull(t, "centos:latest")
+		imagePull(t, "alpine:latest")
 
 		// and
 		path, err := filepath.Abs("testdata")
@@ -235,7 +245,7 @@ func TestClientImpl_Run(t *testing.T) {
 		}
 
 		// when
-		containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "centos", "cat", "/tmp/testdata/data")
+		containerId, _, err := cli.Run(context.New("test/task", uuid.New(), &url.URL{}), opts, "alpine", "cat", "/tmp/testdata/data")
 		if err != nil {
 			t.Fatalf("error occured: %+v", err)
 		}
@@ -261,7 +271,7 @@ func TestClientImpl_Rm(t *testing.T) {
 	}
 
 	// given
-	tag := "alpine:3.5"
+	tag := "alpine:latest"
 	imagePull(t, tag)
 	containerId := containerCreate(t, tag)
 
@@ -564,6 +574,19 @@ func containerWait(t *testing.T, containerId string) {
 	}
 }
 
+func removeImage(t *testing.T, name string) {
+	t.Helper()
+
+	cli, err := client.NewEnvClient()
+	if err != nil {
+		t.Fatalf("error occured. %+v", err)
+	}
+
+	if _, err := cli.ImageRemove(context.New("test/task", uuid.New(), &url.URL{}), name, types.ImageRemoveOptions{}); err != nil {
+		t.Fatalf("error occured. %+v", err)
+	}
+}
+
 func removeContainer(t *testing.T, containerId string) {
 	t.Helper()