Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in migration guide #816

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix typos in migration guide #816

merged 1 commit into from
Jul 29, 2020

Conversation

102
Copy link
Contributor

@102 102 commented Jul 29, 2020

Why is this PR for?

It fixes small typos in v2 migration guide

In a nutshell

❌ New feature
❌ Fix an issue
✔️ Documentation improvement
❌ Other: please explain

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08a5245:

Sandbox Source
Vanilla Configuration
dubzzz/fast-check: example Configuration

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 95.582% when pulling 08a5245 on 102:patch-1 into ddcad3c on dubzzz:master.

Copy link
Owner

@dubzzz dubzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌
Thanks for the contribution.

Concerning the decrease in coverage, it's a known issue. Some code paths are not run every time (as some of our tests are written using pbt).

@dubzzz dubzzz merged commit 093c681 into dubzzz:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants