Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script to an nmp package for compatibility on with windows: mkdir -p --> mkdirp (#626). #632

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

markkulube
Copy link
Contributor

Issue #626

Why is this PR for?

This script, defined in the root package.json, makes use of mkdir -p which is not working on Windows. We should replace it by the npm package mkdirp

Describe the reason of this PR or give a link towards the associated issue.
#626

In a nutshell

❌ New feature
✔️ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(✔️: yes, ❌: no)

Potential impacts

If you expect some noticeable impacts with your change please explain.

Here are some examples of impacts that might be reported into this section:

  • Generated values impact,
  • Shrink values impact,
  • Performance impact,
  • Typings impact

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91c572c:

Sandbox Source
nifty-liskov-nzj4n Configuration
angry-cohen-6qq8u Configuration

@coveralls
Copy link

coveralls commented Jun 16, 2020

Coverage Status

Coverage increased (+0.007%) to 95.747% when pulling 91c572c on markkulube:master into 0817607 on dubzzz:master.

package.json Show resolved Hide resolved
@dubzzz dubzzz merged commit d3014e3 into dubzzz:master Jun 17, 2020
@dubzzz
Copy link
Owner

dubzzz commented Jun 17, 2020

Thanks a lot for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants