-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Easier replay of failing scheduler #588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzzz
changed the title
Easier replay of failing scheduler
🚧✨ Easier replay of failing scheduler
May 3, 2020
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df325f1:
|
…ly to build the schedulerFor
dubzzz
changed the title
🚧✨ Easier replay of failing scheduler
✨ Easier replay of failing scheduler
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR for?
Replaying issues with occuring with schedulers can be a bit more painful than with other arbitraries. While using
seed
andpath
perfectly works today, users cannot set their own ordering.Following this PR users will be able to give an hardcoded ordering of tasks.
Fixes #595
In a nutshell
✔️ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain
(✔️: yes, ❌: no)
Potential impacts
The
stringified
value of aScheduler
has been updated in order to allow easier to simply copy and paste failing scheduler to have a custom example.