Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Easier replay of failing scheduler #588

Merged
merged 11 commits into from
May 19, 2020
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 3, 2020

Why is this PR for?

Replaying issues with occuring with schedulers can be a bit more painful than with other arbitraries. While using seed and path perfectly works today, users cannot set their own ordering.

Following this PR users will be able to give an hardcoded ordering of tasks.

Fixes #595

In a nutshell

✔️ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(✔️: yes, ❌: no)

Potential impacts

The stringified value of a Scheduler has been updated in order to allow easier to simply copy and paste failing scheduler to have a custom example.

@dubzzz dubzzz marked this pull request as draft May 3, 2020 22:02
@dubzzz dubzzz changed the title Easier replay of failing scheduler 🚧✨ Easier replay of failing scheduler May 3, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df325f1:

Sandbox Source
nice-stallman-ze154 Configuration
competent-haslett-ih0bn Configuration

@coveralls
Copy link

coveralls commented May 15, 2020

Coverage Status

Coverage decreased (-0.05%) to 96.007% when pulling df325f1 on feat/better-replay-on-scheduler into ddd7d2f on master.

@dubzzz dubzzz changed the title 🚧✨ Easier replay of failing scheduler ✨ Easier replay of failing scheduler May 19, 2020
@dubzzz dubzzz marked this pull request as ready for review May 19, 2020 20:56
@dubzzz dubzzz merged commit 5747499 into master May 19, 2020
@dubzzz dubzzz deleted the feat/better-replay-on-scheduler branch May 19, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier replay of failing scheduler
2 participants