Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "sideEffects" to false into package.json #438

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 6, 2019

Why is this PR for?

This flag can be used by webpack to enable tree-shaking on the module.
See https://webpack.js.org/guides/tree-shaking/

In a nutshell

✔️ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(✔️: yes, ❌: no)

Potential impacts

None.

This flag can be used by webpack to enable tree-shaking on the module.
See https://webpack.js.org/guides/tree-shaking/
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 96.707% when pulling d3e06b3 on feat/add-side-effects-packagejson into 9013969 on master.

@dubzzz dubzzz merged commit 16e95f5 into master Oct 6, 2019
@dubzzz dubzzz deleted the feat/add-side-effects-packagejson branch October 6, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants