Support all the range of valid ipV4 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to a recent thread on Twitter, it seems that fast-check already support all the range of IPv6 addresses: https://twitter.com/ndubien/status/1161190040212516869?s=19 |
|
Maybe an update missing for |
|
IPv6 can still be treated by adding 0 or mixing upper case and lower case within the same IP address It will be treated as a FAR |
dubzzz
commented
Sep 6, 2019
src/check/arbitrary/IpArbitrary.ts
Outdated
| return `0${Number(v).toString(8)}`; | ||
| case 'hex': | ||
| return `0x${Number(v).toString(16)}`; | ||
| case 'HEX': |
There was a problem hiding this comment.
Not needed anymore: the uppercase can be handled by the feature #426
dubzzz
force-pushed
the
fest/ipv4-extended
branch
from
b8335df to
e0b34d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.