Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands generator should not rely on arrays generator #221

Merged
merged 8 commits into from
Oct 13, 2018
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 13, 2018

Fixes #192

Before this development fc.commands was relying on fc.array to build and shrink commands correctly.
Unfortunately, with this setup it was not possible to benefit from assumptions we can make on commands while shrinking them:

  • the last started command should always be kept because it is the one causing the failure (or none of the commands caused the failure)
  • string representation was featuring dash (-) for non executed commands
  • string representation was not reliable when commands were used along with other shrinkable arbitraries

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 91.734% when pulling 5210427 on feat/commands into 81e8adc on master.

@dubzzz dubzzz merged commit a9e48e3 into master Oct 13, 2018
@dubzzz dubzzz deleted the feat/commands branch October 13, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants