Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noDuplicates on Property #62

Closed
dubzzz opened this issue Mar 30, 2018 · 1 comment
Closed

Add noDuplicates on Property #62

dubzzz opened this issue Mar 30, 2018 · 1 comment

Comments

@dubzzz
Copy link
Owner

dubzzz commented Mar 30, 2018

Handle the case where generator cannot return unseen values anymore

@dubzzz dubzzz changed the title Add noDuplicates on Arbitrary Add noDuplicates on Property Mar 30, 2018
@dubzzz dubzzz added this to the v1.0.0 milestone Apr 2, 2018
@dubzzz
Copy link
Owner Author

dubzzz commented Apr 6, 2018

Instead of adding a noDuplicates feature, the idea is to remove the unnecessary zero values produced by the fc.integer() shrink.

Basically if the failing range is [1, 20] and it failed first at 18, it will try the following values:
0, 9, 0, 5, 0, 3, 0, 2, 0, 1

The idea is too keep this fast convergence towards zero but do not shrink to it after:
0, 9, 5, 3, 2, 1

It solves partially the issue as values can still be duplicated but the fix is far less intruisive and better in terms of performances and reliability.

dubzzz added a commit that referenced this issue Apr 6, 2018
@dubzzz dubzzz closed this as completed in d1dde51 Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant