Clean unused variables in units

Related #448
dubzzz · Nov 6, 2019 · 7959330 · 7959330
1 parent e739bd6
commit 7959330
Show file tree

Hide file tree

Showing 22 changed files with 100 additions and 100 deletions.
diff --git a/test/e2e/SkipAllAfterTime.spec.ts b/test/e2e/SkipAllAfterTime.spec.ts
@@ -21,7 +21,7 @@ describe(`SkipAllAfterTime (seed: ${seed})`, () => {
   it('should interrupt as soon as delay expires and mark run as success (no failure before)', () => {
     let numRuns = 0;
     const out = fc.check(
-      fc.property(fc.integer(), x => {
+      fc.property(fc.integer(), _n => {
         ++numRuns;
         return true;
       }),
@@ -37,7 +37,7 @@ describe(`SkipAllAfterTime (seed: ${seed})`, () => {
   it('should interrupt as soon as delay expires and mark run as failure if asked to', () => {
     let numRuns = 0;
     const out = fc.check(
-      fc.property(fc.integer(), x => {
+      fc.property(fc.integer(), _n => {
         ++numRuns;
         return true;
       }),
@@ -53,7 +53,7 @@ describe(`SkipAllAfterTime (seed: ${seed})`, () => {
   it('should consider interrupt with higer priority than skip', () => {
     let numRuns = 0;
     const out = fc.check(
-      fc.property(fc.integer(), x => {
+      fc.property(fc.integer(), _n => {
         ++numRuns;
         return true;
       }),

diff --git a/test/unit/check/arbitrary/ArrayArbitrary.spec.ts b/test/unit/check/arbitrary/ArrayArbitrary.spec.ts
@@ -16,7 +16,7 @@ class DummyArbitrary extends Arbitrary<{ key: number }> {
   constructor(public value: () => number) {
     super();
   }
-  generate(mrng: Random): Shrinkable<{ key: number }> {
+  generate(_mrng: Random): Shrinkable<{ key: number }> {
     return new Shrinkable({ key: this.value() });
   }
 }

diff --git a/test/unit/check/arbitrary/DateArbitrary.utest.spec.ts b/test/unit/check/arbitrary/DateArbitrary.utest.spec.ts
@@ -17,7 +17,7 @@ describe('DateArbitrary', () => {
     it('Should be able to build the minimal valid date', () => {
       // Arrange
       const { integer } = mocked(IntegerArbitraryMock);
-      integer.mockImplementationOnce((a, b) => arbitraryFor([{ value: a }]));
+      integer.mockImplementationOnce((a, _b) => arbitraryFor([{ value: a }]));
 
       // Act
       const arb = date();

diff --git a/test/unit/check/arbitrary/LetRecArbitrary.spec.ts b/test/unit/check/arbitrary/LetRecArbitrary.spec.ts
@@ -11,7 +11,7 @@ describe('LetRecArbitrary', () => {
       const expectedArb1 = buildArbitrary(jest.fn());
       const expectedArb2 = buildArbitrary(jest.fn());
 
-      const { arb1, arb2 } = letrec(tie => ({
+      const { arb1, arb2 } = letrec(_tie => ({
         arb1: expectedArb1,
         arb2: expectedArb2
       }));
@@ -20,7 +20,7 @@ describe('LetRecArbitrary', () => {
       expect(arb2).toBe(expectedArb2);
     });
     it('Should not produce LazyArbitrary for no-tie constructs', () => {
-      const { arb } = letrec(tie => ({
+      const { arb } = letrec(_tie => ({
         arb: buildArbitrary(jest.fn())
       }));
       expect(arb).not.toBeInstanceOf(LazyArbitrary);

diff --git a/test/unit/check/arbitrary/MixedCaseArbitrary.utest.spec.ts b/test/unit/check/arbitrary/MixedCaseArbitrary.utest.spec.ts
@@ -26,7 +26,7 @@ describe('MixedCaseArbitrary', () => {
     it('should not toggle any character if flags are null', () => {
       // Arrange
       const { bigUintN } = mocked(BigIntArbitraryMock);
-      bigUintN.mockImplementationOnce(n => arbitraryFor([{ value: BigInt(0) }]));
+      bigUintN.mockImplementationOnce(_n => arbitraryFor([{ value: BigInt(0) }]));
       const stringArb = arbitraryFor([{ value: 'azerty' }]);
 
       // Act
@@ -40,7 +40,7 @@ describe('MixedCaseArbitrary', () => {
     it('should toggle characters according to flags', () => {
       // Arrange
       const { bigUintN } = mocked(BigIntArbitraryMock);
-      bigUintN.mockImplementationOnce(n => arbitraryFor([{ value: BigInt(9) /* 001001 */ }]));
+      bigUintN.mockImplementationOnce(_n => arbitraryFor([{ value: BigInt(9) /* 001001 */ }]));
       const stringArb = arbitraryFor([{ value: 'azerty' }]);
 
       // Act
@@ -54,7 +54,7 @@ describe('MixedCaseArbitrary', () => {
     it('should toggle both lower and upper characters', () => {
       // Arrange
       const { bigUintN } = mocked(BigIntArbitraryMock);
-      bigUintN.mockImplementationOnce(n => arbitraryFor([{ value: BigInt(9) /* 001001 */ }]));
+      bigUintN.mockImplementationOnce(_n => arbitraryFor([{ value: BigInt(9) /* 001001 */ }]));
       const stringArb = arbitraryFor([{ value: 'azERty' }]);
 
       // Act
@@ -68,7 +68,7 @@ describe('MixedCaseArbitrary', () => {
     it('should not try to toggle characters that do not have lower/upper versions', () => {
       // Arrange
       const { bigUintN } = mocked(BigIntArbitraryMock);
-      bigUintN.mockImplementationOnce(n => arbitraryFor([{ value: BigInt(0) }]));
+      bigUintN.mockImplementationOnce(_n => arbitraryFor([{ value: BigInt(0) }]));
       const stringArb = arbitraryFor([{ value: 'az01ty' }]); // 01 upper version is the same
 
       // Act
@@ -149,7 +149,7 @@ describe('MixedCaseArbitrary', () => {
     it('should use toggle function when provided to check what can be toggled or not', () => {
       // Arrange
       const { bigUintN } = mocked(BigIntArbitraryMock);
-      bigUintN.mockImplementationOnce(n => arbitraryFor([{ value: BigInt(63) /* 111111 */ }]));
+      bigUintN.mockImplementationOnce(_n => arbitraryFor([{ value: BigInt(63) /* 111111 */ }]));
       const stringArb = arbitraryFor([{ value: 'azerty' }]);
       const customToggle = jest.fn();
       customToggle.mockImplementation((c: string) => {

diff --git a/test/unit/check/arbitrary/ObjectArbitrary.spec.ts b/test/unit/check/arbitrary/ObjectArbitrary.spec.ts
@@ -130,7 +130,7 @@ describe('ObjectArbitrary', () => {
           const mrng = new Random(prand.xorshift128plus(seed));
           let shrinkable = anything().generate(mrng);
           const originalValue = shrinkable.value;
-          while (shrinkable.shrink().has(v => true)[0]) {
+          while (shrinkable.shrink().has(_ => true)[0]) {
             shrinkable = shrinkable.shrink().next().value;
           } // only check one shrink path
           assertShrinkedValue(originalValue, shrinkable.value);
@@ -282,7 +282,7 @@ describe('ObjectArbitrary', () => {
           const mrng = new Random(prand.xorshift128plus(seed));
           let shrinkable = json().generate(mrng);
           const originalValue = shrinkable.value;
-          while (shrinkable.shrink().has(v => true)[0]) {
+          while (shrinkable.shrink().has(_ => true)[0]) {
             shrinkable = shrinkable.shrink().next().value;
           } // only check one shrink path
           expect(typeof shrinkable.value).toEqual('string');
@@ -312,7 +312,7 @@ describe('ObjectArbitrary', () => {
           const mrng = new Random(prand.xorshift128plus(seed));
           let shrinkable = unicodeJson().generate(mrng);
           const originalValue = shrinkable.value;
-          while (shrinkable.shrink().has(v => true)[0]) {
+          while (shrinkable.shrink().has(_ => true)[0]) {
             shrinkable = shrinkable.shrink().next().value;
           } // only check one shrink path
           expect(typeof shrinkable.value).toEqual('string');
@@ -398,7 +398,7 @@ describe('ObjectArbitrary', () => {
         fc.property(fc.integer(), seed => {
           const mrng = new Random(prand.xorshift128plus(seed));
           let shrinkable = object().generate(mrng);
-          while (shrinkable.shrink().has(v => true)[0]) {
+          while (shrinkable.shrink().has(_ => true)[0]) {
             shrinkable = shrinkable.shrink().next().value;
           } // only check one shrink path
           return typeof shrinkable.value === 'object' && Object.keys(shrinkable.value).length === 0;

diff --git a/test/unit/check/arbitrary/OneOfArbitrary.spec.ts b/test/unit/check/arbitrary/OneOfArbitrary.spec.ts
@@ -16,7 +16,7 @@ class CustomArbitrary extends Arbitrary<number> {
   constructor(readonly value: number) {
     super();
   }
-  generate(mrng: Random): Shrinkable<number> {
+  generate(_mrng: Random): Shrinkable<number> {
     function* g(v: number) {
       yield new Shrinkable(v - 42);
     }

diff --git a/test/unit/check/arbitrary/OptionArbitrary.spec.ts b/test/unit/check/arbitrary/OptionArbitrary.spec.ts
@@ -28,7 +28,7 @@ describe('OptionArbitrary', () => {
         fc.property(fc.integer(), fc.integer(), (seed, start) => {
           const mrng = stubRng.mutable.fastincrease(seed);
           let shrinkable = option(stubArb.withShrink(start)).generate(mrng);
-          while (shrinkable.shrink().has(v => true)[0]) {
+          while (shrinkable.shrink().has(_ => true)[0]) {
             shrinkable = shrinkable.shrink().next().value;
           } // only check one shrink path
           return shrinkable.value === null;

diff --git a/test/unit/check/arbitrary/UuidArbitrary.utest.spec.ts b/test/unit/check/arbitrary/UuidArbitrary.utest.spec.ts
@@ -20,7 +20,7 @@ describe('UuidArbitrary', () => {
       const { nat, integer } = mocked(IntegerArbitraryMock);
       const { tuple } = mocked(TupleArbitraryMock);
       nat.mockImplementation(() => arbitraryFor([{ value: 0 }, { value: 0 }, { value: 0 }]));
-      integer.mockImplementation((a, b) => arbitraryFor([{ value: a }]));
+      integer.mockImplementation((a, _b) => arbitraryFor([{ value: a }]));
       tuple.mockImplementation((...arbs) => arbitraryFor([{ value: arbs.map(a => a.generate(mrng()).value_) as any }]));
 
       // Act
@@ -57,7 +57,7 @@ describe('UuidArbitrary', () => {
       const { nat, integer } = mocked(IntegerArbitraryMock);
       const { tuple } = mocked(TupleArbitraryMock);
       nat.mockImplementation(() => arbitraryFor([{ value: 0 }, { value: 0 }]));
-      integer.mockImplementation((a, b) => arbitraryFor([{ value: a }]));
+      integer.mockImplementation((a, _b) => arbitraryFor([{ value: a }]));
       tuple.mockImplementation((...arbs) => arbitraryFor([{ value: arbs.map(a => a.generate(mrng()).value_) as any }]));
 
       // Act

diff --git a/test/unit/check/arbitrary/definition/Arbitrary.spec.ts b/test/unit/check/arbitrary/definition/Arbitrary.spec.ts
@@ -36,16 +36,16 @@ class FakeNoBiasArbitrary extends Arbitrary<number> {
   generate(mrng: Random): Shrinkable<number> {
     return new ForwardArbitrary().generate(mrng);
   }
-  withBias(freq: number) {
+  withBias(_freq: number) {
     return new ForwardArbitrary();
   }
 }
 
 class FakeTwoValuesBiasArbitrary extends Arbitrary<number> {
-  generate(mrng: Random): Shrinkable<number> {
+  generate(_mrng: Random): Shrinkable<number> {
     return new Shrinkable(44);
   }
-  withBias(freq: number) {
+  withBias(_freq: number) {
     return new (class extends Arbitrary<number> {
       generate(mrng: Random): Shrinkable<number> {
         return mrng.nextInt(1, 2) === 1 ? new Shrinkable(42) : new Shrinkable(43);
@@ -175,7 +175,7 @@ describe('Arbitrary', () => {
       fc.assert(
         fc.property(fc.integer(), (seed: number) => {
           const mrng = stubRng.mutable.fastincrease(seed);
-          const fmapper = (v: number) => new ForwardArbitrary();
+          const fmapper = (_v: number) => new ForwardArbitrary();
           const arb = constant(0).chain(fmapper);
           const biasedArb = arb.withBias(1); // 100% of bias - not recommended outside of tests
           const g = biasedArb.generate(mrng).value;

diff --git a/test/unit/check/arbitrary/definition/ArbitraryWithShrink.spec.ts b/test/unit/check/arbitrary/definition/ArbitraryWithShrink.spec.ts
@@ -8,7 +8,7 @@ import { Stream, stream } from '../../../../../src/stream/Stream';
 
 describe('ArbitraryWithShrink', () => {
   const arbWithShrink = new (class extends ArbitraryWithShrink<number> {
-    generate(mrng: Random): Shrinkable<number> {
+    generate(_mrng: Random): Shrinkable<number> {
       throw new Error('Method not implemented.');
     }
     shrink(value: number, shrunkOnce?: boolean): Stream<number> {

diff --git a/test/unit/check/arbitrary/generic/GenericArbitraryHelper.ts b/test/unit/check/arbitrary/generic/GenericArbitraryHelper.ts
@@ -134,7 +134,7 @@ export const isValidArbitrary = function<U, T>(
   const biasedArbitraryBuilder = ([biasedFactor, u]: [(number | null), U]) => {
     return biasedFactor != null ? arbitraryBuilder(u).withBias(biasedFactor) : arbitraryBuilder(u);
   };
-  const biasedIsValidValue = (g: T, [biasedFactor, u]: [(number | null), U]) => {
+  const biasedIsValidValue = (g: T, [_biasedFactor, u]: [(number | null), U]) => {
     return settings.isValidValue(g, u);
   };
 

diff --git a/test/unit/check/model/ModelRunner.spec.ts b/test/unit/check/model/ModelRunner.spec.ts
@@ -74,7 +74,7 @@ describe('ModelRunner', () => {
           calledBeforeDataReady = calledBeforeDataReady || !setupDataReady;
           return true;
         };
-        run = async (m: {}, r: {}) => {
+        run = async (_m: {}, _r: {}) => {
           calledBeforeDataReady = calledBeforeDataReady || !setupDataReady;
         };
       })();

diff --git a/test/unit/check/model/commands/CommandWrapper.spec.ts b/test/unit/check/model/commands/CommandWrapper.spec.ts
@@ -9,17 +9,17 @@ type Real = {};
 describe('CommandWrapper', () => {
   it('Should show name of the command if it has not run', () => {
     const cmd = new (class implements Command<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = (m: Model, r: Real) => {};
+      check = (_m: Readonly<Model>) => true;
+      run = (_m: Model, _r: Real) => {};
       toString = () => 'sync command';
     })();
     const wrapper = new CommandWrapper(cmd);
     expect(wrapper.toString()).toEqual('sync command');
   });
   it('Should show name of the command if it has run', () => {
     const cmd = new (class implements Command<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = (m: Model, r: Real) => {};
+      check = (_m: Readonly<Model>) => true;
+      run = (_m: Model, _r: Real) => {};
       toString = () => 'sync command';
     })();
     const wrapper = new CommandWrapper(cmd);
@@ -28,8 +28,8 @@ describe('CommandWrapper', () => {
   });
   it('Should reset run flag of clone', () => {
     const cmd = new (class implements Command<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = (m: Model, r: Real) => {};
+      check = (_m: Readonly<Model>) => true;
+      run = (_m: Model, _r: Real) => {};
       toString = () => 'sync command';
     })();
     const wrapper = new CommandWrapper(cmd);
@@ -40,8 +40,8 @@ describe('CommandWrapper', () => {
   });
   it('Should consider a run on success', () => {
     const cmd = new (class implements Command<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = (m: Model, r: Real) => {};
+      check = (_m: Readonly<Model>) => true;
+      run = (_m: Model, _r: Real) => {};
       toString = () => 'sync command';
     })();
     const wrapper = new CommandWrapper(cmd);
@@ -51,8 +51,8 @@ describe('CommandWrapper', () => {
   });
   it('Should consider a run on failure', () => {
     const cmd = new (class implements Command<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = (m: Model, r: Real) => {
+      check = (_m: Readonly<Model>) => true;
+      run = (_m: Model, _r: Real) => {
         throw 'failure message';
       };
       toString = () => 'sync command';
@@ -64,8 +64,8 @@ describe('CommandWrapper', () => {
   });
   it('Should consider a run on asynchronous success', async () => {
     const cmd = new (class implements AsyncCommand<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = async (m: Model, r: Real) => {};
+      check = (_m: Readonly<Model>) => true;
+      run = async (_m: Model, _r: Real) => {};
       toString = () => 'async command';
     })();
     const wrapper = new CommandWrapper(cmd);
@@ -75,8 +75,8 @@ describe('CommandWrapper', () => {
   });
   it('Should consider a run on asynchronous failure', async () => {
     const cmd = new (class implements AsyncCommand<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = async (m: Model, r: Real) => {
+      check = (_m: Readonly<Model>) => true;
+      run = async (_m: Model, _r: Real) => {
         throw 'failure message';
       };
       toString = () => 'async command';

diff --git a/test/unit/check/model/commands/CommandsIterable.spec.ts b/test/unit/check/model/commands/CommandsIterable.spec.ts
@@ -11,8 +11,8 @@ type Real = {};
 const buildAlreadyRanCommands = (runFlags: boolean[]) => {
   return runFlags.map((hasRun, idx) => {
     const cmd = new (class implements Command<Model, Real> {
-      check = (m: Readonly<Model>) => true;
-      run = (m: Model, r: Real) => {};
+      check = (_m: Readonly<Model>) => true;
+      run = (_m: Model, _r: Real) => {};
       toString = () => String(idx);
     })();
     const wrapper = new CommandWrapper(cmd);