Add sortBy saleAmount #1869
Merged
Add sortBy saleAmount #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Changed `sort` to `sortBy` in LinksDisplayContext and related components for consistency. - Updated `getLinksForWorkspace` to support legacy `sort` parameter while transitioning to `sortBy`. - Refined `getLinksQuerySchemaExtended` to streamline sorting logic and removed unnecessary transformation. - Added new sorting option for "Sales Amount" in the LinksDisplayProvider. This commit enhances the clarity and maintainability of the sorting functionality across the application.
- Updated `getLinks` operation to utilize `getLinksQuerySchemaBase` instead of `getLinksQuerySchema`. - Exported `getLinksQuerySchemaBase` from the links schema file for improved accessibility. This change enhances the consistency and clarity of the query parameters used in the `getLinks` operation.
- Introduced `sortOrder` and updated `order` handling in `getEvents` to improve sorting logic. - Updated analytics schemas to replace `order` with `sortOrder` for clarity and consistency. - Modified `EventsTable` component to utilize new `sortOrder` and `sortBy` parameters from search queries. - Deprecated the `order` parameter in favor of `sortOrder` to streamline event sorting functionality. These changes enhance the maintainability and clarity of event sorting across the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.