Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement commits full sync #744

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

frolosofsky
Copy link
Member

@frolosofsky frolosofsky commented Mar 6, 2019

Adds implementation of finalizer-commits based full sync as described in UIP-21.

Also, moves src/finalization/p2p to src/p2p and makes a component from it. Here:

  1. Move p2p commits handlers from src/finalizarion/p2p* to src/p2p/finalizer_commits*.
  2. Rename commits to FinalizerCommits in type and file names.
  3. Pack commits handlers in the component FinalizerCommitsHandler.
  4. Adds PushMessage helper function to net_processing.

Fixes #219.

@frolosofsky frolosofsky self-assigned this Mar 6, 2019
@frolosofsky frolosofsky added the p2p label Mar 6, 2019
@frolosofsky frolosofsky added this to the 0.1 milestone Mar 6, 2019
@frolosofsky frolosofsky force-pushed the commits-full-sync branch 2 times, most recently from 8ecd771 to 2746e4b Compare March 7, 2019 09:37
@frolosofsky frolosofsky requested review from scravy, Gnappuraz, AM5800, thothd and a team March 7, 2019 09:42
@frolosofsky frolosofsky marked this pull request as ready for review March 7, 2019 09:43
@frolosofsky frolosofsky changed the title Commits full sync Implement commits full sync Mar 7, 2019
@frolosofsky

This comment has been minimized.

@frolosofsky frolosofsky added the wip Work in progress which is not supposed to be merged yet label Mar 7, 2019
@thothd thothd requested a review from kostyantyn March 7, 2019 10:40
@frolosofsky frolosofsky removed the wip Work in progress which is not supposed to be merged yet label Mar 7, 2019
@frolosofsky frolosofsky force-pushed the commits-full-sync branch 2 times, most recently from efae4e3 to f59760f Compare March 7, 2019 14:18
@frolosofsky frolosofsky force-pushed the commits-full-sync branch 2 times, most recently from e050c60 to d68e60e Compare March 11, 2019 11:08
Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConceptACK a761adf

There are few comments that should be resolved or answered. Especially the one about replacing CheckFinalizationTx with ContextualCheckFinalizationTx.

Signed-off-by: Stanislav Frolov <[email protected]>
Signed-off-by: Stanislav Frolov <[email protected]>
Signed-off-by: Stanislav Frolov <[email protected]>
@frolosofsky frolosofsky merged commit c225302 into dtr-org:master Mar 20, 2019
@frolosofsky frolosofsky deleted the commits-full-sync branch March 20, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants