-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement commits full sync #744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ecd771
to
2746e4b
Compare
This comment has been minimized.
This comment has been minimized.
kostyantyn
reviewed
Mar 7, 2019
efae4e3
to
f59760f
Compare
e050c60
to
d68e60e
Compare
castarco
reviewed
Mar 11, 2019
castarco
reviewed
Mar 11, 2019
castarco
reviewed
Mar 11, 2019
castarco
reviewed
Mar 11, 2019
castarco
reviewed
Mar 11, 2019
castarco
reviewed
Mar 11, 2019
kostyantyn
reviewed
Mar 18, 2019
kostyantyn
reviewed
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConceptACK a761adf
There are few comments that should be resolved or answered. Especially the one about replacing CheckFinalizationTx
with ContextualCheckFinalizationTx
.
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
kostyantyn
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
AM5800
reviewed
Mar 19, 2019
Signed-off-by: Stanislav Frolov <[email protected]>
Signed-off-by: Stanislav Frolov <[email protected]>
Signed-off-by: Stanislav Frolov <[email protected]>
Signed-off-by: Stanislav Frolov <[email protected]>
72277de
to
149034e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation of finalizer-commits based full sync as described in UIP-21.
Also, moves src/finalization/p2p to src/p2p and makes a component from it. Here:
src/finalizarion/p2p*
tosrc/p2p/finalizer_commits*
.commits
toFinalizerCommits
in type and file names.FinalizerCommitsHandler
.Fixes #219.