Add infallible expr scanner fallback for scanning invalid code #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: this function's return value is unnecessarily wrapped by `Result`
--> impl/src/fmt.rs:122:1
|
122 | / fn explicit_named_args(input: ParseStream) -> Result<Set<Ident>> {
123 | | let ahead = input.fork();
124 | | if let Ok(set) = try_explicit_named_args(&ahead) {
125 | | input.advance_to(&ahead);
... |
136 | | Ok(Set::new())
137 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
= note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_wraps)]`
help: remove `Result` from the return type...
|
122 | fn explicit_named_args(input: ParseStream) -> std::collections::BTreeSet<proc_macro2::Ident> {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: ...and then change returning expressions
|
126 ~ return set;
127 | }
...
131 | input.advance_to(&ahead);
132 ~ return set;
133 | }
134 |
135 | input.parse::<TokenStream>().unwrap();
136 ~ Set::new()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infallible scanner has the same behavior as prior to #337, which exhibits bugs like #335 but that's okay because fallback is only going to be applied if the format arguments do not consist of syntactically valid expressions. This is useful for an IDE performing macro expansions while code is being typed.