stricter parsing of string_continue escapes

dtolnay · Feb 23, 2023 · 62d0aed · 62d0aed
1 parent 4168f6b
commit 62d0aed
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/lit.rs b/src/lit.rs
@@ -1117,9 +1117,9 @@ mod value {
                         b'\'' => '\'',
                         b'"' => '"',
                         b'\r' | b'\n' => loop {
-                            let ch = next_chr(s);
-                            if ch.is_whitespace() {
-                                s = &s[ch.len_utf8()..];
+                            let b = byte(s, 0);
+                            if matches!(b, b' ' | b'\t' | b'\n' | b'\r') {
+                                s = &s[1..];
                             } else {
                                 continue 'outer;
                             }

diff --git a/tests/test_lit.rs b/tests/test_lit.rs
@@ -50,6 +50,10 @@ fn strings() {
         "\"contains\nnewlines\\\nescaped newlines\"",
         "contains\nnewlinesescaped newlines",
     );
+    test_string(
+        "\"escaped newline\\\n \x0C unsupported whitespace\"",
+        "escaped newline\x0C unsupported whitespace",
+    );
     test_string("r\"raw\nstring\\\nhere\"", "raw\nstring\\\nhere");
     test_string("\"...\"q", "...");
     test_string("r\"...\"q", "...");