Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impls will panic on a null pointer. Panicking in Deref is unconventional but this matches the reality of how unique_ptr is used in practice in C++. In most places that unique_ptr is passed around they can never be null, and in the few cases where null is allowed the programmer is responsible for keeping track and handling those pointers carefully.
Providing these impls is less bad than users writing
ptr.as_ref().unwrap()
everywhere, because at least this way we can get the panic message to include type info to help debugging.