Document and static assert assumptions on size_t layout #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust specifies that usize is ABI compatible with C's uintptr_t: https://rust-lang.github.io/unsafe-code-guidelines/layout/scalars.html#isize-and-usize. However there is no direct Rust equivalent for size_t. C does not guarantee that size_t and uintptr_t are compatible. In practice though, on all platforms supported by Rust, they are identical for ABI purposes. See the libc crate which unconditionally defines libc::size_t = usize. We expect the same here and the assertions in this PR are just to explicitly document that.
Note that no assumption is made about C++ name mangling of signatures containing these types, not here nor anywhere in CXX.