Support C-style enums #170
Conversation
This adds support for passing C-style enums between Rust and C++. We use the Rust representation for enums suggested by dtolnay in dtolnay#132. Note that as this does not use real enums, Rust code cannot treat them as normal enums, e.g., by converting them to integers. But common uses such as pattern matching remain unchanged.
|
Note that I decided to duplicate the logic for computing discriminants in check.rs and expand and check.rs to keep parsing close to the original syntax. But we could of course compute discriminants there to avoid the duplication. And as an aside the logic for parsing a variant is slightly ugly; I don't know if we prefer more nested matches instead. |
|
It looks like the tests are failing because nightly rustc gives a different error message. Is there a way to configure it to change that test based on the compiler, maybe by modifying .travis.yml, or should we just delete that one test for now? |
|
Because of this line, we only run ui tests on nightly, so the expected error message files should match what is emitted by current nightly. I don't think maintaining additional expected outputs for different compilers would be productive. Line 1 in d776519 |
This adds support for passing C-style enums between Rust and C++.
We use the Rust representation for enums suggested by dtolnay in #132.
Note that as this does not use real enums, Rust code cannot treat them
as normal enums, e.g., by converting them to integers. But common
uses such as pattern matching remain unchanged.