Ergonomics: allow constructing rust::Slice from any C++ container.
#1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this commit, it is possible to explicitly construct `rust::Slice` from a reference to any continguous C++ container (any container that exposes `data` and `size` accessors). The new constructor results in a slightly more ergonomic code, by removing the need to explicit extract and pass `c.data()` and `c.size()` at a callsite of a `rust::Slice` constructor. The callsites using the new constructor are also more obviously correct, because they doesn't require double-checking that the passed `data` and `size` match. The implementation of the new constructor mimics `std::span` from C++20, but for C++11 compatibility reimplements `std::size` / `std::ranges::size` in a pedestrian way (same for `std::data` / `std::ranges::data`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this commit, it is possible to explicitly construct
rust::Slicefrom a reference to any continguous C++ container (any container that exposesdataandsizeaccessors).The new constructor results in a slightly more ergonomic code, by removing the need to explicit extract and pass
c.data()andc.size()at a callsite of arust::Sliceconstructor. The callsites using the new constructor are also more obviously correct, because they doesn't require double-checking that the passeddataandsizematch.The implementation of the new constructor mimics
std::spanfrom C++20, but for C++11 compatibility reimplementsstd::size/std::ranges::sizein a pedestrian way (same forstd::data/std::ranges::data).