Skip to content

Commit

Permalink
Delete clippy suppressions that are no longer triggered
Browse files Browse the repository at this point in the history
  • Loading branch information
dtolnay committed Dec 27, 2024
1 parent fb82424 commit e247ca0
Show file tree
Hide file tree
Showing 10 changed files with 4 additions and 68 deletions.
2 changes: 0 additions & 2 deletions flags/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
//! This crate is an implementation detail of the `cxx` and `cxx-build` crates,
//! and does not expose any public API.
#![allow(clippy::let_and_return)]

mod r#impl;

#[doc(hidden)]
Expand Down
11 changes: 1 addition & 10 deletions gen/build/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,38 +50,29 @@
#![allow(
clippy::cast_sign_loss,
clippy::default_trait_access,
clippy::derive_partial_eq_without_eq,
clippy::doc_markdown,
clippy::enum_glob_use,
clippy::explicit_auto_deref,
clippy::if_same_then_else,
clippy::inherent_to_string,
clippy::into_iter_without_iter,
clippy::items_after_statements,
clippy::match_bool,
clippy::match_on_vec_items,
clippy::match_same_arms,
clippy::module_name_repetitions,
clippy::needless_doctest_main,
clippy::needless_lifetimes,
clippy::needless_pass_by_value,
clippy::new_without_default,
clippy::nonminimal_bool,
clippy::or_fun_call,
clippy::redundant_else,
clippy::ref_option,
clippy::shadow_unrelated,
clippy::significant_drop_in_scrutinee,
clippy::similar_names,
clippy::single_match_else,
clippy::struct_excessive_bools,
clippy::struct_field_names,
clippy::too_many_arguments,
clippy::too_many_lines,
clippy::toplevel_ref_arg,
clippy::unconditional_recursion, // clippy bug: https://github.com/rust-lang/rust-clippy/issues/12133
clippy::uninlined_format_args,
clippy::upper_case_acronyms,
clippy::upper_case_acronyms
)]

mod cargo;
Expand Down
9 changes: 0 additions & 9 deletions gen/cmd/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,28 +1,19 @@
#![cfg_attr(not(check_cfg), allow(unexpected_cfgs))]
#![allow(
clippy::cast_sign_loss,
clippy::cognitive_complexity,
clippy::default_trait_access,
clippy::derive_partial_eq_without_eq,
clippy::enum_glob_use,
clippy::if_same_then_else,
clippy::inherent_to_string,
clippy::into_iter_without_iter,
clippy::items_after_statements,
clippy::large_enum_variant,
clippy::map_clone,
clippy::match_bool,
clippy::match_on_vec_items,
clippy::match_same_arms,
clippy::module_name_repetitions,
clippy::needless_lifetimes,
clippy::needless_pass_by_value,
clippy::new_without_default,
clippy::nonminimal_bool,
clippy::or_fun_call,
clippy::redundant_else,
clippy::ref_option,
clippy::shadow_unrelated,
clippy::similar_names,
clippy::single_match_else,
clippy::struct_excessive_bools,
Expand Down
7 changes: 0 additions & 7 deletions gen/lib/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,19 @@
#![allow(
clippy::cast_sign_loss,
clippy::default_trait_access,
clippy::derive_partial_eq_without_eq,
clippy::enum_glob_use,
clippy::if_same_then_else,
clippy::inherent_to_string,
clippy::into_iter_without_iter,
clippy::items_after_statements,
clippy::match_bool,
clippy::match_on_vec_items,
clippy::match_same_arms,
clippy::missing_errors_doc,
clippy::module_name_repetitions,
clippy::must_use_candidate,
clippy::needless_lifetimes,
clippy::needless_pass_by_value,
clippy::new_without_default,
clippy::nonminimal_bool,
clippy::or_fun_call,
clippy::redundant_else,
clippy::ref_option,
clippy::shadow_unrelated,
clippy::similar_names,
clippy::single_match_else,
clippy::struct_excessive_bools,
Expand Down
14 changes: 1 addition & 13 deletions macro/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,34 +1,22 @@
#![allow(
clippy::cast_sign_loss,
clippy::default_trait_access,
clippy::derive_partial_eq_without_eq,
clippy::doc_markdown,
clippy::enum_glob_use,
clippy::if_same_then_else,
clippy::inherent_to_string,
clippy::into_iter_without_iter,
clippy::items_after_statements,
clippy::large_enum_variant,
clippy::match_bool,
clippy::match_same_arms,
clippy::module_name_repetitions,
clippy::needless_lifetimes,
clippy::needless_pass_by_value,
clippy::new_without_default,
clippy::nonminimal_bool,
clippy::or_fun_call,
clippy::redundant_else,
clippy::ref_option,
clippy::shadow_unrelated,
clippy::similar_names,
clippy::single_match,
clippy::single_match_else,
clippy::struct_field_names,
clippy::too_many_arguments,
clippy::too_many_lines,
clippy::toplevel_ref_arg,
clippy::uninlined_format_args,
clippy::useless_let_if_seq
clippy::uninlined_format_args
)]

mod derive;
Expand Down
16 changes: 1 addition & 15 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -380,32 +380,18 @@
#![allow(non_camel_case_types)]
#![allow(
clippy::cast_possible_truncation,
clippy::cognitive_complexity,
clippy::declare_interior_mutable_const,
clippy::doc_markdown,
clippy::duplicated_attributes, // clippy bug: https://github.com/rust-lang/rust-clippy/issues/12537
clippy::empty_enum,
clippy::extra_unused_type_parameters,
clippy::inherent_to_string,
clippy::items_after_statements,
clippy::large_enum_variant,
clippy::len_without_is_empty,
clippy::missing_errors_doc,
clippy::missing_safety_doc,
clippy::module_inception,
clippy::module_name_repetitions,
clippy::must_use_candidate,
clippy::needless_doctest_main,
clippy::needless_lifetimes,
clippy::new_without_default,
clippy::or_fun_call,
clippy::ptr_arg,
clippy::ptr_as_ptr,
clippy::ptr_cast_constness,
clippy::toplevel_ref_arg,
clippy::transmute_undefined_repr, // clippy bug: https://github.com/rust-lang/rust-clippy/issues/8417
clippy::uninlined_format_args,
clippy::useless_let_if_seq,
clippy::uninlined_format_args
)]

#[cfg(built_with_cargo)]
Expand Down
2 changes: 0 additions & 2 deletions tests/cxx_gen.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![allow(clippy::field_reassign_with_default)]

use cxx_gen::{generate_header_and_cc, Opt};
use std::str;

Expand Down
1 change: 0 additions & 1 deletion tests/cxx_string.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#![allow(
clippy::incompatible_msrv, // https://github.com/rust-lang/rust-clippy/issues/12257
clippy::items_after_statements,
clippy::uninlined_format_args,
clippy::unused_async
Expand Down
5 changes: 0 additions & 5 deletions tests/ffi/lib.rs
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
#![allow(
clippy::boxed_local,
clippy::derive_partial_eq_without_eq,
clippy::just_underscores_and_digits,
clippy::missing_errors_doc,
clippy::missing_safety_doc,
clippy::must_use_candidate,
clippy::needless_lifetimes,
clippy::needless_pass_by_ref_mut,
clippy::needless_pass_by_value,
clippy::ptr_arg,
clippy::trivially_copy_pass_by_ref,
clippy::unnecessary_literal_bound,
clippy::unnecessary_wraps,
clippy::unused_self
Expand Down
5 changes: 1 addition & 4 deletions tests/test.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
#![allow(
clippy::assertions_on_constants,
clippy::assertions_on_result_states,
clippy::cast_possible_truncation,
clippy::cast_possible_wrap,
clippy::float_cmp,
clippy::needless_pass_by_ref_mut,
clippy::needless_pass_by_value,
clippy::ptr_cast_constness,
clippy::unit_cmp,
clippy::unseparated_literal_suffix
clippy::unit_cmp
)]

use cxx::{SharedPtr, UniquePtr};
Expand Down

0 comments on commit e247ca0

Please sign in to comment.