Work around RA's RUSTC_WRAPPER poisoning all subsequent command-line builds #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if someone did a build via rust-analyzer, it would run anyhow's build script through rust-analyzer's questionable RUSTC_WRAPPER (#250), and then future
cargo
invocations done on the command line not via rust-analyzer would bypass the build script, untilcargo clean
or thetarget
dir being deleted.This PR is an alternative to #251 that tries to isolate command-line
cargo
builds from getting poisoned by rust-analyzer's running of the build script and cargo's caching of the build script output. In contrast to #251, this does not attempt to fix builds done through rust-analyzer, only direct cargo invocations. I still consider rust-analyzer's behavior incorrect so I want to not sweep it under the rug; getting that fixed in rust-analyzer will be between the rust-analyzer devs and its users.