Options are not passed correctly to programs

[gschueler]

Using a simple bash script as follows:

#!/bin/bash
echo "Here's the list of command line options:"

for i in "$@"; do
  echo "** $i **"
done

I have defined an option (named "option1") with no default value and no restrictions, so the user can enter any value.
In the job definition, I invoke the command

/path/to/testprog.sh ${option.option1}

If the value entered by the user does not start with a dash, the program receives it correctly; if it starts with a dash, the programs receives the string "true". This looks like a pretty serious bug to me, unless I'm misunderstanding something (which of course is possible).

I'm also having trouble running the same job from the command line, I'll open a separate issue for that.

[satyagraha]

I confirm the problem with leading - values, which is easy to reproduce as above. I was trying to pass Java system properties via a -Dkey=val and got the "true" value. If you pass in this string with a leading space it does get through, and is enclosed in single quotes when substituted.

[gschueler]

I think I understand the problem now, you are saying that if an option value is something like "-value", the value will not be used correctly when passed to the underlying script execution.

My guess is the options parser is incorrectly treating "-optionname -value" as if it were two separate boolean flag options. However, rundeck doesn't (any longer) allow that kind of option, so it must have some lingering improper treatment of the options string.

[buildhive]

DTO Labs » rundeck #47 SUCCESS
This pull request looks good
(what's this?)