-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wilcoxon statistical calculation and plotting to 'yPlot()' and 'freqPlot()' #14
base: main
Are you sure you want to change the base?
Conversation
I recognize this increases complexity dramatically, but being able to use both edit: pp <- dittoPlot(object = myRNA, var = "gene1", group.by = "conditions",
color.by = "timepoint")
pp + geom_pwc(aes(group = timepoint)) |
Agreed that subgroup comparisons would also be very nice, and...
This is also what I discovered! It's just a bit unfortunate to build only half the solution internally and then need to rely on something like internal descriptions reliant on an external tooling, or to maintain pointers to external documentation if I/we find a good The fact that I want to add a |
There's a working implementation for using both
I spent a good bit of time troubleshooting my way through applying the docs that ggpubr points to today for adding p-values between subgroups. Unfortunately, I couldn't seem to make use of the same functions with my p-values generated outside of the rstatix package. BUT I was able to understand the moving pieces enough to re-create them! |
Goal: Add functionality to
yPlot()
andfreqPlot()
to perform statistical testing between frequencies of pairwisegroup.by
-groups (and/orcolor.by
-groups).This is a BIG add in terms of both expected value add to users, and also required code complexity. Currently a work in progress.
An internal function is used to calculate p-values for pairwise comparisons between groupings. The methodology and control points of this function are still evolving, but the plan is to document and export this function for visibility purposes before merge of this PR. The p-values are plotted with
ggpubr::stat_pvalue_manual()
.ToDo before merge:
pvalues.test.method
&pvalues.test.adjust
)pvalues.sample.by
&pvalues.sample.summary
)split.adjust = scale = "free_y"
) instead of just the max and 0-to-maxcolor.by
-groups whengroup.by != color.by
.group.by
when `color.by constitutes super-groups?)do.hover
*
/**
instead of direct pvalues.Supported currently via manual provision of involved inputs toit cannot actually be achieved this way withpvalues.plot.adjust
stat_pvalues_manual
...pvalues.plot.symbols
logical or function (default = FALSE) input make this customizeable yet easy. Symbol definitions are given in the input documentation.NOTE:
freqPlot()
&barPlot()
, accessible viadata.out = TRUE
. The PR uses "Y" as the new name currently, but I may settle on something different before merge.