Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - correct 'plotly-related' yPlot() jitter issue #11

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

dtm2451
Copy link
Owner

@dtm2451 dtm2451 commented Jan 16, 2024

Re-make of #9 since I built my own fix before seeing that version.

Per investigation by @j-andrews7, discovering the root cause of this long-standing dittoSeq-issue, adds a column to the data_frame when needed (group.by and color.by not the same) and uses that column or group.by for explicitly setting the group aesthetic for the jitter geom.

This PR also turns showing hover.data back on for yPlot

I had commented the code for utilizing this data out because of the bug addressed here!

ToDo

  • add tests (and check again for other breakages)
  • assess other do.hover behaviors to get that all more ironed out here
    • add hover.round.digits to control length of numeric values displayed
    • add group.by/sample.by/color.by to the data shown for barPlot() and freqPlot()
    • add presumptive default for scatterPlot() hover.data
    • document

@dtm2451 dtm2451 merged commit 204c225 into main Jan 17, 2024
@dtm2451 dtm2451 deleted the text-group-fix branch January 17, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant