Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix time #143

Closed
wants to merge 3 commits into from
Closed

Nix time #143

wants to merge 3 commits into from

Conversation

The1Penguin
Copy link
Contributor

No description provided.

@The1Penguin
Copy link
Contributor Author

This is a terrible idea.
It forces everyone to use nix to ensure that the builds will be reproducible.
The resulting image is around 40 times larger than it needs to be.
The action is probably wrong as well.
The positive part is that it will build faster.

Multipacker
Multipacker requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@Multipacker Multipacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is terrible

malmz
malmz requested changes Oct 21, 2024
View reviewed changes
.dockerignore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where it go??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

.github/workflows/publish-docker-image.yml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? 😃

Dockerfile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker? 🥺

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got docker at home

docker-compose.yml Show resolved Hide resolved
flake.nix
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't get this, plz explan?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so ponder the following

What if your package manager, could build the entire docker image by itself, and handle the dependencies.
This does that, and a bit more ;P

Multipacker
Multipacker reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@Multipacker Multipacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Multipacker Multipacker Multipacker requested changes

@malmz malmz malmz requested changes

@SwedishSubmarine SwedishSubmarine Awaiting requested review from SwedishSubmarine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The1Penguin @malmz @Multipacker