Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 986 TCPairs support LOOP_BY = VALID when LOOP_ORDER = processes #987

Closed
wants to merge 3 commits into from

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Jul 7, 2021

Modified logic to allow loop by valid time for TCPairs when loop order = PROCESSES.

Pull Request Testing

  • Describe testing already performed for these changes:

Modified unit test logic to test when loop_order = PROCESSES and LOOP_BY = VALID

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes and ensure no differences in automated tests.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 7/7/2021.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Jul 7, 2021
@JohnHalleyGotway JohnHalleyGotway requested review from mollybsmith-noaa and removed request for mollybsmith-noaa July 7, 2021 22:25
@JohnHalleyGotway
Copy link
Collaborator

Per our discussion on 7/7/21, recommend that you:

  • retract this current PR
  • enhance the feature branch to use the lead list to process tracks from all initialization times, init_time = valid_time - lead_list[i]
  • checkout this feature branch on jet and ask @mollybsmith-noaa to test out these changes there

@mollybsmith-noaa please feel free to schedule a meeting with George and I next week to talk through these details more closely as you see fit.

Once @mollybsmith-noaa confirms that these changes meet her need, resubmit a PR.

@georgemccabe
Copy link
Collaborator Author

Closing the PR to make additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance TCPairs to loop by valid time and allow looping when LOOP_ORDER = processes
3 participants