Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 779 add support for output_flag, nc_pairs_flag, and climo_cdf dictionaries in GridStat #858

Merged
merged 30 commits into from
Mar 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1a275c6
add support for climo_cdf dictionary in GridStat
georgemccabe Mar 24, 2021
c8a2731
add support for climo_cdf dictionary in PointStat, ci-run-diff
georgemccabe Mar 24, 2021
a43d4ad
added support for output_flag and nc_pairs_flag in GridStat - updated…
georgemccabe Mar 24, 2021
70c1424
Merge branch 'develop' into feature_779_common_met_config_options
georgemccabe Mar 25, 2021
c2675a7
added more documentation about required arguments for function
georgemccabe Mar 25, 2021
0731862
add support for another METplus config name for climo_cdf.cdf_bins
georgemccabe Mar 25, 2021
764ced3
added utility to easy generate text that is needed to be added to doc…
georgemccabe Mar 25, 2021
e1fb770
added missing header for MET configuration section documentation
georgemccabe Mar 25, 2021
b1fbd63
added other advice for adding support for new MET config variable
georgemccabe Mar 29, 2021
f55b47b
Merge branch 'develop' into feature_779_common_met_config_options
georgemccabe Mar 29, 2021
bf806be
clean up formatting so it is easier to read the output
georgemccabe Mar 29, 2021
e12eebf
moved output_flag and nc_pairs_flag values from GRID_STAT_MET_CONFIG_…
georgemccabe Mar 29, 2021
aa5405a
add env var to GridStat wrapped config, updated documentation for new…
georgemccabe Mar 29, 2021
e73fcb4
trigger diff tests with ci-run-diff
georgemccabe Mar 29, 2021
cb3c38b
changed output_flag and nc_pairs_flag settings to match previous defa…
georgemccabe Mar 29, 2021
e4294b7
ci-run-diff
georgemccabe Mar 29, 2021
4ca0bb6
fixed typo in value for DMAP
georgemccabe Mar 29, 2021
b7abcda
only copy log directory to error_logs if there is an error in the use…
georgemccabe Mar 29, 2021
8ca3e4b
try to using image diff logic for pdf files
georgemccabe Mar 29, 2021
9c5a524
fix output flags to match previous settings, ci-run-diff
georgemccabe Mar 29, 2021
7dfcb72
Revert "fixed typo in value for DMAP"
georgemccabe Mar 29, 2021
24f1753
removed script that is no longer used
georgemccabe Mar 29, 2021
a10ac91
added info for checking default values in MET configs against share/m…
georgemccabe Mar 29, 2021
247f2de
rename script name to be more clear, ci-run-all-cases
georgemccabe Mar 29, 2021
c34926f
removed unused scripts
georgemccabe Mar 29, 2021
92cdfa1
added unsupported file types for diff logic so the output can be obta…
georgemccabe Mar 29, 2021
f3b632a
added comments to scripts to explain what they do and what calls them…
georgemccabe Mar 29, 2021
1aefe35
moved scripts to obtain external python requirements into a directory…
georgemccabe Mar 29, 2021
1fbfffb
change typo back to correct version since I confirmed the error logs …
georgemccabe Mar 29, 2021
667574f
updated doc util script to help generate unit tests, added tests for …
georgemccabe Mar 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/actions/run_tests/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ fi
pip_command="pip3 install Pillow"

# build command to run
command="./ci/jobs/run_use_cases_docker.py ${CATEGORIES} ${SUBSETLIST}"
command="./ci/jobs/run_use_cases.py ${CATEGORIES} ${SUBSETLIST}"

# add input volumes to run command
# keep track of --volumes-from arguments to docker run command
Expand Down
4 changes: 4 additions & 0 deletions ci/jobs/create_output_data_volumes.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#! /bin/bash

# Run by GitHub Actions (in .github/workflows/main.yml) to create
# Docker data volumes from output data to create a "truth"
# data set to use in difference tests.

if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then
echo This is a pull request, so skip this setp
exit 0
Expand Down
3 changes: 3 additions & 0 deletions ci/jobs/diff_output.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#! /usr/bin/env python3

# Run by GitHub Actions (in ci/jobs/run_use_cases.py) to
# trigger difference tests.

import sys
import os

Expand Down
8 changes: 8 additions & 0 deletions ci/jobs/docker_setup.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
#! /bin/bash

# Run by GitHub Actions (in .github/workflows/main.yml) to build
# METplus Docker image and put it up to DockerHub so it can be
# used by the use case tests.
# If GitHub Actions run is triggered by a fork that does not have
# permissions to push Docker images to DockerHub, the script is
# is also called (in ci/actions/run_tests/entrypoint.sh) to
# build the Docker image to use for each use case test group

branch_name=`${GITHUB_WORKSPACE}/ci/jobs/print_branch_name.py`
if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then
branch_name=${branch_name}-pull_request
Expand Down
5 changes: 5 additions & 0 deletions ci/jobs/docker_update_data_volumes.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#! /usr/bin/env python3

# Run by GitHub Actions (in .github/workflows/main.yml) check DTCenter web
# server for any input data tarfiles that have been updated and need to be
# regenerated as Docker data volumes to be used in use case tests.
# Push new/updated data volumes up to DockerHub

import sys
import os
import shlex
Expand Down
5 changes: 5 additions & 0 deletions ci/jobs/docker_utils.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import os
import re

# Utilities used by various CI jobs. Functionality includes:
# - Check if Docker data volumes need to be updated.
# - Get appropriate branch name to use to obtain/create Docker
# images. This is needed for pull request runs.

# repository used for storing input data for development branches
DOCKERHUB_DATA_REPO = 'dtcenter/metplus-data-dev'

Expand Down
38 changes: 0 additions & 38 deletions ci/jobs/download_gempaktocf.py

This file was deleted.

4 changes: 4 additions & 0 deletions ci/jobs/get_artifact_name.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#! /bin/bash

# Run by GitHub Actions (in .github/workflows/main.yml and
# ci/actions/run_tests/entrypoint.sh) to get properly
# formatted artifact name for use case output

artifact_name=$1
# strip of :NEW if found at end of name
if [ ${artifact_name: -4} == ":NEW" ]; then
Expand Down
46 changes: 0 additions & 46 deletions ci/jobs/get_artifacts.py

This file was deleted.

5 changes: 5 additions & 0 deletions ci/jobs/get_data_volumes.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#! /usr/bin/env python3

# Run by GitHub Actions (in ci/actions/run_tests/entrypoint.sh)
# to obtain Docker data volumes for input and output data, create
# an alias name for the volumes, and generate --volumes-from arguments
# that are added to the Docker run command to make data available

import sys
import os
import subprocess
Expand Down
5 changes: 5 additions & 0 deletions ci/jobs/get_use_case_commands.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#! /usr/bin/env python3

# Script to obtain commands needed to run use case groups including
# scripts or pip commands to obtain external Python dependencies
# Run by GitHub Actions (in ci/jobs/run_use_cases.py) to run use case tests

import sys
import os

Expand All @@ -19,6 +23,7 @@ def handle_requirements(requirements, work_dir):
script_path = os.path.join(work_dir,
'ci',
'jobs',
'python_requirements',
f'get_{requirement.lower()}.sh')
print(f"Looking for script: {script_path}")
if os.path.exists(script_path):
Expand Down
1 change: 0 additions & 1 deletion ci/jobs/gha_get_current_branch.sh

This file was deleted.

2 changes: 0 additions & 2 deletions ci/jobs/gha_get_dockerhub_tag.sh

This file was deleted.

4 changes: 4 additions & 0 deletions ci/jobs/print_branch_name.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#! /usr/bin/env python3

# Script to easily get branch name from docker_utils function
# Run by GitHub Actions (in ci/actions/run_tests/entrypoint.sh,
# ci/jobs/create_output_data_volumes.sh, and ci/jobs/docker_setup.sh)

from docker_utils import get_branch_name

print(get_branch_name())
98 changes: 0 additions & 98 deletions ci/jobs/print_log_errors.py

This file was deleted.

3 changes: 3 additions & 0 deletions ci/jobs/print_python_version.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#! /usr/bin/env python3

# Script to easily obtain minimum python version requirement
# Used in GitHub Actions (in ci/jobs/python_requirements/get_miniconda.sh)

import sys
import os

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pip3 install scipy
pip3 install pingouin

basedir=$(dirname "$0")
work_dir=$basedir/../..
work_dir=$basedir/../../..

# run manage externals to obtain METcalcpy
${work_dir}/manage_externals/checkout_externals -e ${work_dir}/ci/parm/Externals_metcalcpy.cfg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pip3 install scipy
pip3 install cmocean

basedir=$(dirname "$0")
work_dir=$basedir/../..
work_dir=$basedir/../../..

# run manage externals to obtain METcalcpy
${work_dir}/manage_externals/checkout_externals -e ${work_dir}/ci/parm/Externals_metplotpy.cfg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

script_dir=$(dirname "$0")

python_version=`${script_dir}/print_python_version.py`
python_version=`${script_dir}/../print_python_version.py`

# these are used to obtain version of MiniConda3
# the version determines the default version of Python
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/bin/bash

#shell script to install pygrib with dependencies
# todd arbetter: [email protected]

yum -y install eccodes-devel
pip3 install numpy
Expand Down
File renamed without changes.
Loading