-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 569 blocking driver #856
Conversation
…nter/METplus into feature_569_blocking_driver Adding some updates
…nter/METplus into feature_569_blocking_driver
Instead of running locally, you can download the artifacts from this GitHub Actions run to view the output data: https://github.com/dtcenter/METplus/actions/runs/687176426 The artifacts are found at the bottom of the summary page for the run when all of the jobs are finished running. Here are direct links: use_cases_s2s_1-3 (output data): HTML documentation: |
Hi George:
It looks like the errors are a result of not finding the output plots to
compare? Do I need to upload this truth data so it has a comparison?
Thanks,
Tina
…On Thu, Mar 25, 2021 at 11:00 AM George McCabe ***@***.***> wrote:
Instead of running locally, you can download the artifacts from this
GitHub Actions run to view the output data:
https://github.com/dtcenter/METplus/actions/runs/687176426
The artifacts are found at the bottom of the summary page for the run when
all of the jobs are finished running. Here are direct links:
use_cases_s2s_1-3 (output data):
https://github.com/dtcenter/METplus/suites/2344516537/artifacts/49513635
HTML documentation:
https://github.com/dtcenter/METplus/suites/2344516537/artifacts/49513635
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#856 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJHD4UA47FPJTMXND7OAM3TFNT3VANCNFSM4ZZXQVVQ>
.
--
*************************************************
Christina Kalb
Associate Scientist
National Center for Atmospheric Research
3450 Mitchell Lane
Boulder, CO 80301
***@***.***
303-497-2819
*************************************************
My working day may not be your working day. Please do not feel obliged to
reply to this email outside of your normal working hours.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the plots were created via presence of GitHub artifacts. Verified that documentation exists.
@CPKalb no, we just need to verify that the only differences are from the new output, which it looks like Minna has already done. Once we merge this PR, I will create another PR to merge develop into develop-ref, which will kick off the generation of new truth data that will include the new output. |
Pull Request Testing
Describe testing already performed for these changes:
The plotting was checked to work in a metplotpy pull request. This is the pull request to merge the blocking code changes to METplus
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
run the three new use cases (UserScript_fcstGFS_obsERA_Blocking.conf, UserScript_obsERA_obsOnly_Blocking.conf, UserScript_obsERA_obsOnly_WeatherRegime.conf). The first use case should output one plot in the plot directory in both pdf and png format (FV3_ERA_IBL_Freq_DJF). The second should output 3 plots in the plot directory both png and pdf format (ERA_Block_Freq_DJF, ERA_CBL_avg, and ERA_IBL_Freq_DJF). The third should output 3 plots and a netcdf file (plots/obs_elbow.png, plots/obs_eof.png, plots/obs_kmeans.png, and obs_weather_regime_class.nc). I can provide previous images if it would be helpful.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Yes
Do these changes include sufficient testing updates? [Yes or No]
Yes
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Yes. New data was uploaded for the use cases to run in the directory: UserScript_obsERA_obsOnly_Blocking
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone