Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update develop-ref after dtcenter/MET#1674 #817

Merged
merged 18 commits into from
Feb 23, 2021
Merged

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Feb 22, 2021

Changes in MET (dtcenter/MET#1674) caused the output filenames from a MODE use case to differ. The change is actually an improvement, as the MET tools now read the accumulation interval from cf-compliant files and use the value in the output filenames.

This PR is simply to trigger the develop-ref branch to regenerate the truth data. This could actually be accomplished by re-triggering the latest develop-ref GitHub Actions run since the code changes in METplus are not responsible for the change. Consider cancelling this PR in favor of doing that.

Pull Request Testing

  • Describe testing already performed for these changes:

    See above

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    See above

  • Do these changes include sufficient documentation and testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    Except for updating the truth data.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 17 commits February 11, 2021 18:28
… indicate whether to use a default resolution or a defined resolution.

Resolution value of 0 indicates "allow Matplotlib to determine the resolution".  Non-zero value indicates a valid resolution.
revert to 20150301 to match up with available sample data
Now draw lines between storm waypoints, allow user to modify resolution, and set annotation text size.
@georgemccabe georgemccabe added this to the METplus-4.0.0 milestone Feb 22, 2021
@georgemccabe georgemccabe merged commit 6094221 into develop-ref Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants