Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2406 usecase rrfs #2484

Closed
wants to merge 60 commits into from
Closed

Feature 2406 usecase rrfs #2484

wants to merge 60 commits into from

Conversation

bikegeek
Copy link
Contributor

@bikegeek bikegeek commented Feb 3, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    on 'seneca':

  • used this environment: /home/met_test/miniforge3/envs/rrfs_usecase_env

  • run from bash shell

  • run: activate /home/met_test/miniforge3/envs/rrfs_usecase_env

  • created a working directory and under this directory:
    - cloned the develop branch of METdataio
    - cloned the develop branch of METcalcpy
    - cloned the develop branch of METplotpy
    - cloned the feature_2406_usecase_RRFS branch of METplus

  • set up the usecase_setup.sh.txt:

    • save in the WORKING_DIR
    • remove .txt extension (this was required to save here)
    • set WORKING_DIR environment value in the script
    • run: source usecase_setup.sh
  • Downloaded sample_data-short_range.tgz from:

  • set up the user.conf.txt file for the user system config file:

    • saved to $WORKING_DIR
    • remove .txt extension (only needed to load file here)
    • using the path to MET on 'seneca'
  • run the use case:

    • from anywhere:
      python $METPLUS_BASE/ush/run_metplus.py $METPLUS_BASE/parm/use_cases/model_applications/short_range/UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot.conf $WORKING_DIR/user.conf
  • Verify that a reformatted file was created in the $METPLUS_BASE/output/reformatted directory:

    • ensemble_stat_ecnt.data
  • Verify that an aggregation statistics file was created in the $METPLUS_BASE/output/aggregated directory:

    • ecnt_aggregated.data
  • Check that a spread-skill was created in the $METPLUS_BASE/output/plot directory and view it, it should look like this:

short-range_UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Perform same steps above

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    Added this use case to the tests in the workflow

  • Will this PR result in changes to the test suite? [Yes]

    Additional data files in the sample_data-short_range.tgz tarball

  • Please complete this pull request review by [COB Monday February 5].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 30 commits January 10, 2024 14:56
…ow consistent with Contributor's Guide instructions)
…RFS_fcstOnly_Reformat.conf

removing, use the full 'reformat-aggregate-plot' version instead
…RFS_fcstOnly_Reformat directory

replaced by the full use case for reformat-aggregate-plot
…ot_ecnt_spread_skill.png to short-range-UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot_ecnt_spread_skill.png

change _ to - in filename to be consistent with naming convention
Remove out of date doc, replace with newer version for RRFS usecase
@bikegeek bikegeek added this to the METplus-6.0.0 milestone Feb 3, 2024
@bikegeek bikegeek requested a review from j-opatz February 3, 2024 03:02
@coveralls
Copy link

coveralls commented Feb 3, 2024

Pull Request Test Coverage Report for Build 7804812150

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.762%

Totals Coverage Status
Change from base Build 7700714846: 0.0%
Covered Lines: 8508
Relevant Lines: 9374

💛 - Coveralls

@georgemccabe georgemccabe linked an issue Feb 5, 2024 that may be closed by this pull request
27 tasks
bikegeek and others added 6 commits February 5, 2024 13:23
…the conf file relative to the METPLUS_BASE
…he METDATAIO_BASE, METCALCPY_BASE, and METPLOTPY_BASE. Instructions specify these to be in the same base directory where METplus is installed
set run to true while debugging
…alcpy, and metplotpy to ensure these are loaded, and use only the metplotpy_env
@bikegeek bikegeek marked this pull request as draft February 6, 2024 18:25
@georgemccabe georgemccabe reopened this Feb 6, 2024
@bikegeek
Copy link
Contributor Author

bikegeek commented Feb 6, 2024

closing due to a large number of empty files under files changed. A new PR will be generated.

@bikegeek bikegeek closed this Feb 6, 2024
@bikegeek bikegeek reopened this Feb 6, 2024
@bikegeek bikegeek marked this pull request as ready for review February 6, 2024 23:37
@bikegeek bikegeek closed this Feb 7, 2024
@bikegeek bikegeek deleted the feature_2406_usecase_RRFS branch February 7, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

New Use Cases: RRFS reformatting, aggregating, and plotting use case
3 participants