-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2406 usecase rrfs #2484
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature_2406_usecase_RRFS
…ow consistent with Contributor's Guide instructions)
…RFS_fcstOnly_Reformat.conf removing, use the full 'reformat-aggregate-plot' version instead
…RFS_fcstOnly_Reformat directory replaced by the full use case for reformat-aggregate-plot
…ot_ecnt_spread_skill.png to short-range-UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot_ecnt_spread_skill.png change _ to - in filename to be consistent with naming convention
…ature_2406_usecase_RRFS
…er/METplus into feature_2406_usecase_RRFS
…ature_2406_usecase_RRFS
Pull Request Test Coverage Report for Build 7804812150
💛 - Coveralls |
27 tasks
…the conf file relative to the METPLUS_BASE
…he METDATAIO_BASE, METCALCPY_BASE, and METPLOTPY_BASE. Instructions specify these to be in the same base directory where METplus is installed
… using the METdataio readconfig
set run to true while debugging
…alcpy, and metplotpy to ensure these are loaded, and use only the metplotpy_env
…er/METplus into feature_2406_usecase_RRFS
…tpy and METdataio
…ature_2406_usecase_RRFS
closing due to a large number of empty files under files changed. A new PR will be generated. |
…er/METplus into feature_2406_usecase_RRFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
on 'seneca':
used this environment: /home/met_test/miniforge3/envs/rrfs_usecase_env
run from bash shell
run: activate /home/met_test/miniforge3/envs/rrfs_usecase_env
created a working directory and under this directory:
- cloned the develop branch of METdataio
- cloned the develop branch of METcalcpy
- cloned the develop branch of METplotpy
- cloned the feature_2406_usecase_RRFS branch of METplus
set up the usecase_setup.sh.txt:
Downloaded sample_data-short_range.tgz from:
set up the user.conf.txt file for the user system config file:
run the use case:
python $METPLUS_BASE/ush/run_metplus.py $METPLUS_BASE/parm/use_cases/model_applications/short_range/UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot.conf $WORKING_DIR/user.conf
Verify that a reformatted file was created in the $METPLUS_BASE/output/reformatted directory:
Verify that an aggregation statistics file was created in the $METPLUS_BASE/output/aggregated directory:
Check that a spread-skill was created in the $METPLUS_BASE/output/plot directory and view it, it should look like this:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Perform same steps above
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Added this use case to the tests in the workflow
Will this PR result in changes to the test suite? [Yes]
Additional data files in the sample_data-short_range.tgz tarball
Please complete this pull request review by [COB Monday February 5].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes