Code

Bugfix #2244 develop fix diff tests#2254

Code

Merged

georgemccabe merged 42 commits intodevelopdtcenter/METplus:developfrom bugfix_2244_develop_fix_diff_testsdtcenter/METplus:bugfix_2244_develop_fix_diff_testsCopy head branch name to clipboardJul 18, 2023

+416-220

Commits

Commits on Jul 12, 2023

• set shallow=False for file comparision because shallow compare can incorrectly consider 2 files equal when their content is not

  georgemccabe

  committed
  f4e6e78

  Copy full SHA for f4e6e78

• pop header line from file b that was incorrectly removed, add check to error if header values differ

  georgemccabe

  committed
  670cabf

  Copy full SHA for 670cabf

• remove header from zip so additional columns in stat files past the length of the header columns are still compared, ci-run-all-diff

  georgemccabe

  committed
  8cbf350

  Copy full SHA for 8cbf350

• error if different number of columns in stat files, include column number to easily identify which columns differ, various clean up

  georgemccabe

  committed
  8b2fc0e

  Copy full SHA for 8b2fc0e

• ci-run-all-diff

  georgemccabe

  committed
  998fd47

  Copy full SHA for 998fd47

Commits on Jul 13, 2023

• change log messages to discern which test determined no diffs, turn on pbl use case to test expected failure, ci-run-diff

  georgemccabe

  committed
  f1898b3

  Copy full SHA for f1898b3

• add blank lines for pep8 standards

  georgemccabe

  committed
  8207e4b

  Copy full SHA for 8207e4b

• refactor to move logic into function, return non-zero if diffs occur when running diff script directly

  georgemccabe

  committed
  6de3620

  Copy full SHA for 6de3620

• skip diff if file path contains a keyword, skip PBL use case

  georgemccabe

  committed
  e6c8f5f

  Copy full SHA for e6c8f5f

• use rounding to compare stat lines instead of exact equal

  georgemccabe

  committed
  6890dc3

  Copy full SHA for 6890dc3

• added function to return boolean if directories are equal

  georgemccabe

  committed
  a1caa8a

  Copy full SHA for a1caa8a

• per #2244, add unit tests for diff utility

  georgemccabe

  committed
  15711ff

  Copy full SHA for 15711ff

• per #2245, use unique run ID to name logger instance to ensure that concurrent runs do not use the same logger instance

  georgemccabe

  committed
  83b2494

  Copy full SHA for 83b2494

Commits on Jul 14, 2023

• per #2249, add a step to Dockerfiles to remove the conda environment that was used to create a new environment to free up space

  georgemccabe

  committed
  da6e5b1

  Copy full SHA for da6e5b1

• create test.v5.1 metplus-env docker image to use for both pytests and diff tests since the pytests will require the packages needed for the diff tests to properly unit test diff_util

  georgemccabe

  committed
  577147d

  Copy full SHA for 577147d

• use new test.v5.1 docker image for pytests

  georgemccabe

  committed
  723a574

  Copy full SHA for 723a574

• updated comparison that includes rounding to properly handle strings by checking if the value is numeric

  georgemccabe

  committed
  5a9548a

  Copy full SHA for 5a9548a

• added unit tests for comparing stat files

  georgemccabe

  committed
  159493b

  Copy full SHA for 159493b

Commits on Jul 17, 2023

• per #2245, add METplusConfig class function that is called when object is deleted to close log handlers. This prevents OSError: [Errno 24] Too many open files from running all pytests

  georgemccabe

  committed
  d5ea70c

  Copy full SHA for d5ea70c

• Merge branch 'develop' into bugfix_2244_develop_fix_diff_tests

  georgemccabe

  committed
  5a27a2e

  Copy full SHA for 5a27a2e

• add doc info

  georgemccabe

  committed
  47795f4

  Copy full SHA for 47795f4

• call all pytests in single call instead of splitting them up by marker

  georgemccabe

  committed
  a9622df

  Copy full SHA for a9622df

• purposely break 1 test to ensure automated test captures failure

  georgemccabe

  committed
  0e8e7d4

  Copy full SHA for 0e8e7d4

• remove commented code after confirming tests run from single command

  georgemccabe

  committed
  c0ad3e4

  Copy full SHA for c0ad3e4

• fix test that was broken on purpose and add check that number of commands are equal

  georgemccabe

  committed
  8b599de

  Copy full SHA for 8b599de

• turn off all use cases for push events

  georgemccabe

  committed
  f30277b

  Copy full SHA for f30277b

• skip test for now to remove dependency on file from MET install dir

  georgemccabe

  committed
  93d26e6

  Copy full SHA for 93d26e6

• remove test that is not needed -- tests do not need to run MET tools

  georgemccabe

  committed
  457987c

  Copy full SHA for 457987c

• update logic to allow wrapper to initialize properly if R scripts do not need to be present -- for unit tests and running METplus without executing commands

  georgemccabe

  committed
  8bb277e

  Copy full SHA for 8bb277e

Commits on Jul 18, 2023

• Removed logic to require minimum_pytest.<host>.sh script to run pytests. Instead require METPLUS_TEST_OUTPUT_BASE to be set in the user's environment to run tests. Add logic to ensure that the outp…

  Show description for e1dd5c6
  georgemccabe

  committed
  e1dd5c6

  Copy full SHA for e1dd5c6

• error and exit if output base is set to a directory where the user does not have write permissions

  georgemccabe

  committed
  702352a

  Copy full SHA for 702352a

• include another valid NetCDF extension

  georgemccabe

  committed
  01bfe21

  Copy full SHA for 01bfe21

• fix logic to check if a pixel in an image has no differences

  georgemccabe

  committed
  3e6616a

  Copy full SHA for 3e6616a

• test if png diff logic will work, ci-run-all-diff

  georgemccabe

  committed
  596a8ef

  Copy full SHA for 596a8ef

• strip off whitespace before diffing column values

  georgemccabe

  committed
  26562d5

  Copy full SHA for 26562d5

• add more tests for csv and stat files. move multiple tests into a single parameterized test

  georgemccabe

  committed
  3b906a3

  Copy full SHA for 3b906a3

• remove file containing pytest groups because they are no longer required to run all of the tests

  georgemccabe

  committed
  59de5c9

  Copy full SHA for 59de5c9

• add diff marker to be able to run all unit tests except the diff utility tests that have additional dependencies that may not be available on all systems

  georgemccabe

  committed
  0982a55

  Copy full SHA for 0982a55

• per #2244, updated documentation about running unit tests. removed section about running use case tests because they are typically run in GitHub Actions instead of locally. Use case tests can still…

  Show description for d3033c6
  georgemccabe

  committed
  d3033c6

  Copy full SHA for d3033c6

• added info about using metplus_config fixture in unit tests

  georgemccabe

  committed
  c147404

  Copy full SHA for c147404

• set DO_NOT_RUN_EXE for all tests to prevent the actual commands from running unless explicitly specified

  georgemccabe

  committed
  10ae204

  Copy full SHA for 10ae204

• clean up documentation about unit tests

  georgemccabe

  committed
  e2db1cf

  Copy full SHA for e2db1cf