Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1828 use case cocorahs #1914

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Conversation

j-opatz
Copy link
Contributor

@j-opatz j-opatz commented Nov 3, 2022

Pull Request Testing

  • Describe testing already performed for these changes:
    Ran use case with METplus paths, checked documentation for accuracy

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    check documentation here:
    make sure that the only errors in automated testing are the new files.
    If you'd like, you can run the use case. Data is on seneca, under /d1/personal/jopatz/model_applications

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:
    New truth data

  • Please complete this pull request review by [Fill in date].
    11/07 COB

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@j-opatz j-opatz added this to the METplus-5.0.0 milestone Nov 3, 2022
@j-opatz j-opatz requested a review from hankenstein2 November 3, 2022 20:13
@j-opatz j-opatz linked an issue Nov 3, 2022 that may be closed by this pull request
23 tasks
Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on seneca and got expected results, all tests except missing data check successfull.

@hankenstein2 hankenstein2 merged commit 0cbf8c4 into develop Nov 4, 2022
@hankenstein2 hankenstein2 deleted the feature_1828_useCase_cocorahs branch November 4, 2022 16:29
georgemccabe added a commit that referenced this pull request Nov 7, 2022
Co-authored-by: Kathryn Newman <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Lisa Goodrich <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: johnhg <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Mrinal Biswas <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: cristianastan2 <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: Molly Smith <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: bikegeek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

New Use Case: Read in precip gauge data for use in METplus with python embedding
2 participants