Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1808 poe temp use case #1839

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Conversation

j-opatz
Copy link
Contributor

@j-opatz j-opatz commented Sep 27, 2022

Pull Request Testing

  • Describe testing already performed for these changes:
    use case was tested and ran successfully on Seneca, data was migrated to Mohawk for availability.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    Review documentation for no mistakes, check that automated testing only finds differences of new files from use case output, and if desired, run the use case. Data is located on Seneca, under /d1/personal/jopatz/model_applications/medium_range/GridStat_fcstGEFS_obsCADB_BinaryObsPOE.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:
    new output from use case

  • Please complete this pull request review by [Fill in date].
    10/14

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@j-opatz j-opatz added this to the METplus-5.0.0 milestone Sep 27, 2022
@j-opatz j-opatz linked an issue Sep 27, 2022 that may be closed by this pull request
24 tasks
Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran use case on seneca and got all expected output. Looked for typos in files and it all looked good.

@hankenstein2 hankenstein2 merged commit 0ab0b2c into develop Oct 5, 2022
@georgemccabe georgemccabe deleted the feature_1808_POE_temp_useCase branch October 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

New Use Case: Probability of Exceedence for 85th percentile temperatures
2 participants