Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature dtcenter/METplus-Internal#17 sonarqube python #1611

Merged
merged 3 commits into from
May 17, 2022

Conversation

hsoh-u
Copy link
Contributor

@hsoh-u hsoh-u commented May 11, 2022

Pull Request Testing

Activated the SonarQube scanning.
The result is avialable at http://mandan:9000/dashboard?id=org.sonarqube%3AMETplus_python_NB

  • Describe testing already performed for these changes:

at seneca

Download METplus from feature_METplus-Internal_17_sonarqube_python
METplus/internal_tests/scanning/./sornaqube/run_nightly.sh develop

OR
runas met_test
/d1/projects/MET/MET_regression/METplus-develop/internal_tests/scanning/sornaqube/run_nightly.sh develop

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the METplus-5.0.0 milestone May 11, 2022
@hsoh-u hsoh-u requested a review from georgemccabe May 11, 2022 21:55
@hsoh-u hsoh-u changed the title Feature me tplus internal 17 sonarqube python Feature dtcenter/METplus-Internal#17 sonarqube python May 11, 2022
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand all of the details of what is run here, but I trust that Howard tested these changes since he was able to get Sonarqube to run on seneca. I don't recall the password to access the report on mandan so I haven't looked it.

@hsoh-u hsoh-u merged commit c10e055 into develop May 17, 2022
@hsoh-u hsoh-u deleted the feature_METplus-Internal_17_sonarqube_python branch May 17, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants