feature 33 (internal) main_v4.1 disable UserScript wrapper #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved from wrappers directory) and report a useful log message suggesting that the wrapper has been disabled before exiting gracefully without crash. Changed exception handling for AttributeError to log an error and return instead of raising another exception.
jprestop
approved these changes
May 11, 2022
There was a problem hiding this comment.
I reviewed the documentation additions. I did not obtain the branch, temporarily remove metplus/wrappers/user_script_wrapper.py, run any use case under parm/use_cases/met_tool_wrapper/UserScript, and review log output due to time constraints, but trust that @georgemccabe tested this well. I approve this PR, pending passing of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1607 for details.