Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1449 v4.1.0 beta6 #1454

Closed
wants to merge 6 commits into from
Closed

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    Reviewed the release notes for beta6 here:
    https://metplus.readthedocs.io/en/feature_1449_v4.1.0-beta6/Users_Guide/release-notes.html#metplus-version-4-1-0-beta6-release-notes-2022-02-18

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    George had already added most of these. Only one was missing which was "Remove support for PB2NC_OBS_PREPBUFR_MAP (#1431)". I added that under "Enhancements" but am not sure that is really the best category, however, it seemed more appropriate than any other category we had. Is this acceptable or should there be a new category and what should it be called? Also, I could use some help with suggestions on what should be bolded.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [ASAP].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop linked an issue Feb 25, 2022 that may be closed by this pull request
@jprestop
Copy link
Collaborator Author

@georgemccabe already added most all of the issues in the release notes. I corresponded with @JohnHalleyGotway via Slack about what to bold and about the placement of "Remove support for PB2NC_OBS_PREPBUFR_MAP". Once the tests finish running, I will go ahead and squash and merge.

@jprestop jprestop closed this Feb 28, 2022
@jprestop jprestop deleted the feature_1449_v4.1.0-beta6 branch February 28, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the METplus v4.1.0-beta6 release
1 participant