Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override MET version used for automated tests #936

Closed
9 of 21 tasks
georgemccabe opened this issue May 26, 2021 · 0 comments · Fixed by #977
Closed
9 of 21 tasks

Add option to override MET version used for automated tests #936

georgemccabe opened this issue May 26, 2021 · 0 comments · Fixed by #977
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: CI/CD Continuous integration and deployment issues priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented May 26, 2021

The METplus use cases run in GitHub Actions uses the develop version of MET. Changes to MET have the potential to break things. For example, if a line type is changed or added, METdatadb may break until it is updated to support the change.

Describe the Enhancement

Add an option to easily set the version of MET to use in case something breaks. This will allow us to use the latest stable release of MET for the tests until things are resolved.

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added the type: enhancement Improve something that it is currently doing label May 26, 2021
@georgemccabe georgemccabe self-assigned this May 26, 2021
@georgemccabe georgemccabe added component: CI/CD Continuous integration and deployment issues priority: high High Priority requestor: METplus Team METplus Development Team labels May 26, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone May 26, 2021
@georgemccabe georgemccabe added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label May 26, 2021
@TaraJensen TaraJensen added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Jun 7, 2021
@georgemccabe georgemccabe linked a pull request Jul 1, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added the reporting: DTC NCAR Base NCAR Base DTC Project label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: CI/CD Continuous integration and deployment issues priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants