Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify wrappers that use wrapped MET config files to default to parm/met_config versions if unset #931

Closed
1 of 21 tasks
georgemccabe opened this issue May 18, 2021 · 3 comments · Fixed by #1037
Closed
1 of 21 tasks

Modify wrappers that use wrapped MET config files to default to parm/met_config versions if unset #931

georgemccabe opened this issue May 18, 2021 · 3 comments · Fixed by #1037
Assignees
@georgemccabe
Labels
METplus: Configuration priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METplus-4.1.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented May 18, 2021 •
edited by TaraJensen
Loading

With the recent changes to how MET configs are overridden via METplus, it is rare that a user will want to override the X_CONFIG_FILE variables to another file.

Describe the Enhancement

We should make these variables (i.e. TC_PAIRS_CONFIG_FILE) optional and default to using the wrapped version, i.e. {PARM_BASE}/met_config/TCPairsConfig_wrapped.

Time Estimate

<1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7740181

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added the type: enhancement Improve something that it is currently doing label May 18, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone May 18, 2021
@georgemccabe georgemccabe added alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: use case configuration priority: high High Priority requestor: METplus Team METplus Development Team labels May 18, 2021
@TaraJensen TaraJensen added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Jun 7, 2021
@georgemccabe georgemccabe self-assigned this Jul 1, 2021
@georgemccabe
Copy link
Collaborator Author

georgemccabe commented Jul 1, 2021 •
edited
Loading

ASCII2NC and STATAnalysis config files are optional, so a default value should not be set for those tools.

georgemccabe added a commit that referenced this issue Jul 1, 2021
@georgemccabe
per #931, added function to read MET config file and used default wra…
c63fb4a 
…pped config file in parm/met_config if unset in METplus config, don't use default value for ASCII2NC and STATAnalysis since their config file is optional
@georgemccabe georgemccabe mentioned this issue Jul 26, 2021
Merged
12 tasks
@georgemccabe georgemccabe linked a pull request Jul 26, 2021 that will close this issue
feature 931 default wrapped MET config file #1037
Merged
12 tasks
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jul 26, 2021
@georgemccabe
Copy link
Collaborator Author

Code changes were merged via PR #1037 but as @jprestop noted, we should update the documentation to add info to the glossary items for the CONFIG_FILE variables to note the default file that is used if it is unset.

@georgemccabe
Copy link
Collaborator Author

Updates to documentation made in commit 8c9c51c. Closing issue.

@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
METplus: Configuration priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Milestone
METplus-4.1.0
Development

Successfully merging a pull request may close this issue.

feature 931 default wrapped MET config file dtcenter/METplus
3 participants
@jprestop @TaraJensen @georgemccabe