Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply TCPairs, TCStat, CyclonePlotter, GridStat to EMC 2020 Data #728

Closed
2 of 21 tasks
fentoad72 opened this issue Dec 10, 2020 · 8 comments · Fixed by #821, #823 or #876
Closed
2 of 21 tasks

Apply TCPairs, TCStat, CyclonePlotter, GridStat to EMC 2020 Data #728

fentoad72 opened this issue Dec 10, 2020 · 8 comments · Fixed by #821, #823 or #876
Assignees
Labels
component: python wrapper METplus: Configuration priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing type: task An actionable item of work
Milestone

Comments

@fentoad72
Copy link
Contributor

Replace italics below with details for this issue.

Describe the Task

Learn how to use TCPairs, TCStat, CyclonePlotter, and GridStat in the context of cyclones, using existing sample data from GitHub

Time Estimate

Estimate the amount of work required here.
3 calendar days of work spread out over December.
Future work will either extend this task or create another one

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

  • John O will provide more data probably in January.*

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@fentoad72 fentoad72 added type: enhancement Improve something that it is currently doing component: python wrapper component: use case configuration priority: medium Medium Priority type: task An actionable item of work requestor: NCAR National Center for Atmospheric Research labels Dec 10, 2020
@fentoad72 fentoad72 added this to the METplus Future Versions milestone Dec 10, 2020
@fentoad72
Copy link
Contributor Author

I've run through the wrappers using the canned data under /d1/projects/METplus/METplus_data successfully.

Then I wrote a python program to look at the 2020 verification data and extract the 000 hour forecast files into an analyses file. Not sure if the Python program is part of this issue or should be made into a new issue.

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Dec 29, 2020 via email

@fentoad72 fentoad72 changed the title Learn how to use TCPairs, TCStat, CyclonePlotter, GridStat Apply TCPairs, TCStat, CyclonePlotter, GridStat to EMC 2020 Data Jan 14, 2021
@fentoad72
Copy link
Contributor Author

I've gotten a sample storm through TCPairs, CyclonePlotter, and TCStat.

Next is to update repo as FeatureRelative cases may have changed

Then try to get the sample storm through the FeatureRelative cases

@georgemccabe georgemccabe linked a pull request Feb 25, 2021 that will close this issue
14 tasks
@fentoad72 fentoad72 linked a pull request Feb 25, 2021 that will close this issue
10 tasks
@TaraJensen TaraJensen added the requestor: NOAA/other NOAA Laboratory, not otherwise specified label Mar 31, 2021
@j-opatz
Copy link
Contributor

j-opatz commented Apr 5, 2021

Reopening this to create a new PR that addresses a few issues with the embedded script

@j-opatz j-opatz reopened this Apr 5, 2021
@j-opatz
Copy link
Contributor

j-opatz commented Apr 7, 2021

With the plotting error corrected and Python script updated to place the A and B deck in separate directories (to avoid reading in both decks as A decks and B decks), a new issue occurred where the resulting image is no longer comparable to Guang Ping's website imagery.
After a discussion with George, the central problem with the use case seems to be how TCPairs is being utilized. The tool is best suited for single storm files, not entire seasons or all storms in one file. This is even stated in the MET User's Guide. Currently the use case pushes one Adeck and one Bdeck that contains all storms with a valid warning time of 2020100700 (~430 storms). Combined with the inclusion of the unique name identifier column, TCPairs does its best to match up the two files but expectedly, encounters many issues.
The tested path will be twofold: the first is to eliminate the extra column, bringing the file in line with ATCF format. The second is to utilize the embedded Python script to create a separate A and B deck file for each storm, with a unique file name to identify the pair for TCPairs. This is much closer to the intended use of TCPairs and should result in more meaningful output.

@j-opatz
Copy link
Contributor

j-opatz commented Apr 7, 2021

Including here the shell script currently being run on Guang Ping's website.
verify_pair_glbl.sh.txt

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 7, 2021 via email

@j-opatz
Copy link
Contributor

j-opatz commented Apr 8, 2021

Success: yesterday a working group with @JohnHalleyGotway and @georgemccabe had the breakthrough for this use case. The solution was in simplifying what was the actual end-goal; that is, to produce a picture comparable to Guang Ping's. Because extra TCs lack an authentic analysis track, the Adecks that were pulled from the source file needed to serve as their own analysis tracks, essentially creating a 1:1 track plot. At this time we aren't concerned with an analysis file; that's already done for us, inside the modified source file. This use case is a multi-step plotting example, pure and simple.
Future work includes allowing METplus to create these modified source files and plotting via METplotpy, possibly including the option to filter storms by their forecast length (to even better match the website output), but that work should reside in a separate use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: python wrapper METplus: Configuration priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing type: task An actionable item of work
Projects
None yet
6 participants